Repository navigation
fix: include typing marker in built distributions - #287
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the import package name
redshift_connectoras thepackage_datakey. Setuptools expects a package name here, so the distribution-styleredshift-connectorkey does not includepy.typedon older builders.Motivation and Context
Fixes #257. Wheels built without the marker prevent downstream type checkers from using the driver's inline annotations, despite the earlier typing support in #224.
Testing
setup.py sdist bdist_wheel: the original wheel omitspy.typed; the patched wheel includes it. Both retain the certificate file.No live Redshift integration tests were run; this change affects package contents only.
Types of changes
Checklist
./build.shbuild command succeedspytest test/unitand they are passing