Repository navigation
py.typed marker file not included in published wheel #257
Description
Activity
TL;DR: potential fix is to just change
package_data={"redshift-connector": ...in setup.py topackage_data={"redshift_connector": ...What might be happening is that it is due to the "-" vs "_" in the package name at
https://github.com/aws/amazon-redshift-python-driver/blob/master/setup.py#L97
setup( name="redshift_connector", version=__version__, # type: ignore
and
https://github.com/aws/amazon-redshift-python-driver/blob/master/setup.py#L131include_package_data=True, package_data={"redshift-connector": ["*.py", "*.crt", "LICENSE", "NOTICE", "py.typed"]}, packages=find_packages(exclude=["test*"]),
I'm not all that familiar with using setuptools, so I'm not sure if the difference there matters (even though those normalize to the same name)
The setuptools docs include this section on how the different package data configuration options interact
To include some data file into the .whl:
(not exclude-package-data) and ((include-package-data and MANIFEST.in) or package-data)
In other words, the file should not be excluded byexclude-package-data(highest priority), AND should be either:- selected by
package-data; or - selected by
MANIFEST.inAND useinclude-package-data = true.
The current setup is trying to add any .crt files as well as the LICENSE, NOTICE, and py.typed files using the
package_dataoption, but I don't see anything except the .crt files included in the published wheelThe
MANIFEST.inisinclude redshift_connector/files/* recursive-include files *.crt
Since
include_package_datais set to True, it seems that thepackage_dataconfiguration is not being included (i.e. rule 1 is never true) and the only extra files being added are those from rule 2.Reacted by Ian Fosbery- selected by
Related to #223
The changes from #224 should have resulted in the py.typed marker file being included in the published wheel (following the instructions in the setuptools docs and the example package included in PEP561
When I build the package locally, the file is included; however, the layout I get in the locally built wheel is slightly different than the published version, so there is definitely some configuration or setuptools/wheel version difference.