fix(media): accept portrait video resolutions

[jedwards27]

Summary

• apply the existing 2160×3840 video resolution envelope independent of orientation
• accept portrait recordings whose short/long edges fit that envelope
• retain rejection coverage for either edge exceeding its limit
• make the relay error describe the orientation-independent limits

Why

The iOS simulator produces portrait H.264 recordings such as 1206×2622. The relay previously checked width <= 3840 && height <= 2160, so the equivalent portrait dimensions were rejected while landscape dimensions were accepted.

Validation

• bin/just ci
• cargo test -p buzz-media (120 passed; one MinIO integration test ignored by its existing live-service guard)
• cargo clippy -p buzz-media --all-targets -- -D warnings
• exact blocked artifact /Users/judeedwards/.buzz/.scratch/pr5874-mongo-evidence/native/head-20260816T050317Z/video-bitexact.mp4 validated through validate_video_file: 1206×2622 accepted

[jedwards27]

A Team review — CLEAR at ad653f6dddb3da27f09c78bbc0a2ccb27322f3ed

Carl, Mongo, and Princess Donut independently reviewed this exact head and found no material correctness, security, compatibility, reliability, or user-trust issues.

• crates/buzz-media/src/validation.rs:373-381 correctly normalizes encoded dimensions to short/long edges, preserving the existing 2160×3840 resource ceiling while removing orientation bias.
• Validation remains before S3 publication (crates/buzz-media/src/upload.rs:417-425,465-467).
• The revised 422 text matches the orientation-independent contract (crates/buzz-media/src/error.rs:75-79).

Exact-head evidence across the three independent passes:

• just ci passed, including Rust workspace tests (2440 passed, 15 ignored), Desktop suites, and Mobile (1465 passed).
• cargo test -p buzz-media passed (120 passed; the existing live-MinIO test remained ignored).
• cargo clippy -p buzz-media --all-targets -- -D warnings, formatting, and diff checks passed.
• The formerly blocked H.264 recording (SHA-256 9f6cb239352a204ea706155462a84d3c228c78b3d53fb912418f1942223c6621, 1206×2622) validated and returned those dimensions.
• Causal mutations were effective: restoring the old orientation-sensitive predicate rejected the portrait artifact/test, while removing either short-edge or long-edge guard failed its matching boundary test.

Residual evidence gap: we did not repeat the live authenticated MinIO upload round-trip. Validation ordering was traced directly, the complete repository gate passed, and the exact production-shaped artifact plus causal controls exercised the changed boundary, so this is not material for this predicate-only change.

Merge recommendation: approve this exact head. Any head movement reopens review.

[themiguelamador]

Reviewed the exact head ad653f6dddb3da27f09c78bbc0a2ccb27322f3ed exhaustively. No findings.

The short/long-edge normalization preserves the existing 2160×3840 pixel envelope while removing the orientation bias, the parser reports encoded H.264 sample-entry dimensions (so the comparison targets the intended resource bound), and the error contract and boundary coverage are consistent.

Verification: cargo test -p buzz-media (120 passed; one existing live-service integration test ignored), strict all-target clippy, workspace formatting, and diff checks all passed.

[wesbillman]

Carl, an automated reviewer, commenting via Wes’s GitHub account.

Royal Court consolidated review: CLEAR

Reviewed exact head ad653f6dddb3da27f09c78bbc0a2ccb27322f3ed. Carl, Princess Donut, Mongo, and Mordecai found no material correctness, security, compatibility, reliability, or user-trust defects.

• crates/buzz-media/src/validation.rs:373-381 normalizes the parser-reported encoded dimensions with min/max. This removes orientation bias while preserving both existing resource ceilings: short edge ≤ 2160 and long edge ≤ 3840.
• The boundary tests cover the exact accepted portrait limit and independent +1 failures for each guard (validation.rs:2554-2589); the existing oversized landscape test remains.
• Returned and persisted metadata preserves the original width/height order (validation.rs:384-389, upload.rs:469-478), so portrait descriptors are not accidentally transposed.
• Full validation still precedes S3 publication (upload.rs:417-466), so the broader orientation acceptance does not create a storage bypass.
• mp4 0.14.0 returns these dimensions as u16, making the conversions and comparisons overflow-safe.
• The revised 422 text accurately states the orientation-independent contract (error.rs:75-79).
• git diff --check passed. A repository-tree search found no second active 3840×2160 validator or stale user-facing resolution contract. GitHub reports the exact head mergeable; a merge-tree check against current origin/main found no conflicts.

The head has not moved since the earlier exact-head validation recorded on this PR, which included the complete repository gate, cargo test -p buzz-media, strict clippy, the real 1206×2622 H.264 artifact, and causal mutation checks. We did not duplicate those CI-equivalent suites.

Non-blocking caveat: the branch is 41 commits behind current main. It currently merges cleanly, but any rebase or other head movement reopens this verdict.

[wesbillman]

Carl, an automated reviewer, approving via Wes’s GitHub account.

Royal Court approval for exact head ad653f6dddb3da27f09c78bbc0a2ccb27322f3ed. No material findings. Any head movement reopens review.