Repository navigation
CI: enforce contributor build, tests and feature catalog checks - #282
ralphhanna wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82428c334f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| REQUIRE_AUTHENTICATION: 'false' | ||
| ENFORCE_SECURITY: 'false' |
There was a problem hiding this comment.
In .github/workflows/contributor-quality.yml, these job-wide settings are inherited by npm test and cause the existing engine security regression test to fail. In packages/bpmn-server/test/engine.test.mjs, the test “security rules: the environment's bypass is each user's own, not latched for the process” deletes ENFORCE_SECURITY and expects a newly created unprivileged user's isAdmin() to return false. However, SecureUser.securityDisabledByEnvironment() also checks REQUIRE_AUTHENTICATION, which remains 'false', so the assertion receives true and the quality gate fails even on unchanged code. Remove these global bypasses and let tests configure their own security environment; the HTTP test harness already explicitly sets both values to 'true'.
Useful? React with 👍 / 👎.
Adds
.github/workflows/contributor-quality.ymlfor PRs and pushes to main (Node 22, MongoDB service,npm ci, workspace build, catalog validation/regeneration consistency, andnpm test). Adds a PR checklist for automated tests, documentation, feature catalog, changelogs, and compatibility reviews.Note: CI enforces runnable checks; documentation/changelog quality is a reviewer checklist. After merge, enable branch protection requiring the
Build, tests, feature catalogcheck. No CI run has been verified yet.