Add GH issue and pull request templates. - #20
Conversation
Add the CONTRIBUTING and GitHub issue templates to the repo, adapted from those in dapr/java-sdk and dapr-sandbox/component-dotnet-sdk. Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
| @@ -0,0 +1,19 @@ | |||
| --- | |||
There was a problem hiding this comment.
FYI: the .NET Dapr Client SDK has this template as well, but it doesn't actually show up in the list of issue types (and GH complains about an invalid name). I wasn't able to find the cause of the error, so I left it out of the .NET Dapr Pluggable Components SDK.
There was a problem hiding this comment.
The issue happens because there are two config files in ISSUES_TEMPLATE in the dotnet SDK with the same name value:
Changing the name on discussion.md should fix the problem.
There was a problem hiding this comment.
| name: Bug report | ||
| about: Report a bug in Dapr's Java Pluggable Components SDK | ||
| title: '' | ||
| labels: kind/bug |
There was a problem hiding this comment.
Make sure to define the labels from the issues page.
There was a problem hiding this comment.
Interesting that you mentioned that and we already have 'Bug' and other labels by default. Curious why we went for the kind prefix
There was a problem hiding this comment.
I asked @artursouza and he said that this kind/ prefix was something they picked up from other OSS projects and that this setup is being used by dapr/dapr. I renamed the labels accordingly so this merge should work just fine.
philliphoff
left a comment
philliphoff
left a comment
There was a problem hiding this comment.
Just a couple of minor comments.
2 participants
Add the CONTRIBUTING and GitHub issue templates to the repo, adapted from those in dapr/java-sdk and dapr-sandbox/components-dotnet-sdk.