Fix name in dicussion.md - #1026
Merged
Merged
Conversation
dicussion.md `name` field was colliding with feature_request.md `name`, causing both to be unusable. Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
Codecov Report
@@ Coverage Diff @@
## master #1026 +/- ##
==========================================
- Coverage 69.47% 69.45% -0.02%
==========================================
Files 162 162
Lines 5432 5432
Branches 585 585
==========================================
- Hits 3774 3773 -1
- Misses 1518 1519 +1
Partials 140 140
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
halspang
approved these changes
Feb 22, 2023
yash-nisar
pushed a commit
to yash-nisar/dotnet-sdk
that referenced
this pull request
Feb 27, 2023
dicussion.md `name` field was colliding with feature_request.md `name`, causing both to be unusable. Signed-off-by: Tiago Alves Macambira <tmacam@burocrata.org>
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dicussion.md
namefield was colliding with feature_request.mdname, causing both to be unusable:dotnet-sdk/.github/ISSUE_TEMPLATE/discussion.md
Line 2 in 22ac4c5
dotnet-sdk/.github/ISSUE_TEMPLATE/feature_request.md
Line 2 in 22ac4c5
Changing the name on
discussion.mdshould fix the problem.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: