Add net7 to testing matrix - #1005
Conversation
8b0759f to
7a19457
Compare
Codecov Report
@@ Coverage Diff @@
## master #1005 +/- ##
==========================================
- Coverage 69.92% 69.90% -0.02%
==========================================
Files 157 157
Lines 5227 5227
Branches 562 562
==========================================
- Hits 3655 3654 -1
- Misses 1439 1440 +1
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
73a1397 to
216b657
Compare
There was a problem hiding this comment.
Does this work on downlevel .NET versions? eg: is this API present pre-7.0?
There was a problem hiding this comment.
Yes, it is present for 3.1-7, though only 7 appears to handle cookies incorrectly. Given this comes from the integration suite, I believe it doesn't represent an issue with our standard code and I did manually test the actor example with net7 to ensure this isn't an issue.
There was a problem hiding this comment.
What's the reason for this change?
There was a problem hiding this comment.
I added that when I was debugging the cookie issue. I'll remove it.
|
You should be able to also remove .NET 5 from your testing matrix as it was EOL in May 2022. This is not a breaking change since it doesn't break anything for a .NET 5 user. We'll just stop testing it. |
Signed-off-by: halspang <halspang@microsoft.com>
2 participants
Description
Add net7 into the testing framework to ensure compatibility.
Signed-off-by: halspang halspang@microsoft.com
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: NA
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: