remove .NET5 (out of support runtime) from test projects - #955
Closed
heavenwing wants to merge 1 commit into
Closed
heavenwing wants to merge 1 commit into
heavenwing wants to merge 1 commit into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #955 +/- ##
==========================================
- Coverage 69.49% 69.47% -0.02%
==========================================
Files 155 155
Lines 5130 5130
Branches 554 554
==========================================
- Hits 3565 3564 -1
- Misses 1434 1435 +1
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Yongguang Zhu <yoz@microsoft.com>
heavenwing
force-pushed
the
removeNET5
branch
from
September 23, 2022 11:25
2649c91 to
5582436
Compare
Contributor
|
@heavenwing - Thanks for this PR! However, we'd want to give more warning about removing a build target. These are also only test targets, so we're making sure we still support that version. Instead of just the PR, can you create an issue and we can prioritize it through the standard milestone process? |
Contributor
|
I actually ended up doing this in #1005. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
remove .NET5 TargetFrameworks from test projects, because .NET5 is out of support runtime.
Issue reference
N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: