Conversation
DeviceFinderBase.RaiseIsolated still traced subscriber failures with Trace.WriteLine inside an empty catch after #763 moved the composite finder onto DiagnosticGuard.SafeTrace. Compose that line inside SafeTrace and keep the outer catch that isolates subscribers. Rewrite the WifiModuleUpdater flag comment so cancel and failure match TryLeaveLanUpdateModeAfterFailureAsync (#788): best-effort transparent-mode exit, settle, then LAN:APPLY, without persisting LAN:ENAbled/SAVE. Co-authored-by: Tyler Kron <tylerkron@gmail.com>
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two Core hygiene leftovers, behavior unchanged aside from routing the existing diagnostic line through the shared guard.
DeviceFinderBase.RaiseIsolatedstill logged a throwing subscriber withTrace.WriteLineinside an empty catch.AllTransportsDeviceFinderalready usesDiagnosticGuard.SafeTrace. This copy now does too. The line is composed inside the guard so a throwingToStringon the subscriber exception cannot escape. The outer catch that swallows subscriber exceptions stays —SafeTraceonly replaces the inner logging try/catch.mayBeInLanUpdateModecomment still said only the success path leaves LAN/USB-transparent mode, and that a failed or canceled flash strands the device. Cancel and failure both callTryLeaveLanUpdateModeAfterFailureAsync: best-effortSetUsbTransparencyMode(0),PostUsbTransparentModeExitDelay, thenLAN:APPLY. That sequence does not persistLAN:ENAbled/SAVE. Comment only; the recovery method is untouched.Test plan
DeviceFinderBaseTests(subscriber isolation) — passed, net9.0 and net10.0WifiModuleUpdaterTests(comment-only; suite stays green) — passed, net9.0 and net10.0DiagnosticGuardTests(SafeTrace contract the finder now depends on) — passed, net9.0 and net10.0Local filter:
FullyQualifiedName~DeviceFinderBaseTests|FullyQualifiedName~WifiModuleUpdaterTests|FullyQualifiedName~DiagnosticGuardTests— 44 passed / 0 failed on each TFM.