Conversation
Switch the five eager SafeTrace($"…{ex}") sites on the stream-event and
discovery isolation catches to the Func<string> overload so a throwing
ToString stays inside the guard.
Document that DeviceState.Streaming is never assigned and that live
acquisition state is IStreamingDevice.IsStreaming.
Co-authored-by: Tyler Kron <tylerkron@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two hygiene items in
src/Daqifi.Core. No public member added or removed.DaqifiStreamingDevice(RaiseStreamFrameDiscarded,RaiseGapDetected) andAllTransportsDeviceFinder(RaiseIsolated, bothSafeDiscoverAsyncoverloads) interpolatedexbeforeSafeTracecould catch it, so a throwingToStringescaped the catch that exists to contain it. Those five sites now useSafeTrace(Func<string>), the same overloadSerialStreamTransportandTcpStreamTransportalready use, so formatting stays inside the guard.DeviceState.Streamingstays (shipped; removing it isCP0002). Nothing assigns it: after initializationDaqifiDevice.StateremainsReady, and live acquisition isIStreamingDevice.IsStreaming. The enum summary now says that.DeviceFinderBase(#806) andCompositeMessageParser(#810) are untouched.Test plan
dotnet build src/Daqifi.Core/Daqifi.Core.csproj -c Release— net9.0 and net10.0, 0 warnings