Repository navigation
Revert "perf(desktop): serve over in-process memory channel instead of TCP loopback (#35272)" - #35670
Merged
Conversation
…f TCP loopback (denoland#35272)" This reverts commit 4925b0e.
Contributor
|
This also fixes #35590 (Vite template desktop app renders a blank window). Root cause there is the |
This was referenced Jul 1, 2026
bartlomieju
approved these changes
Jul 1, 2026
littledivy
added a commit
that referenced
this pull request
Jul 1, 2026
…instead of TCP loopback (#35272)\" (#35670)" This reverses the release-branch revert so the in-memory transport is back in place. The next commit adds the WebSocket loopback proxy that was the missing piece: the reason #35670 was needed at all was that user code doing `new WebSocket("ws://" + window.location.host)` couldn't reach `Deno.serve` when it was bound only to the memory channel. Reintroducing the transport in isolation would reproduce that regression — the follow-up commit is what makes it viable. Refs #35576 Co-Authored-By: Divy Srivastava <me@littledivy.com>
This was referenced Jul 7, 2026
littledivy
added a commit
that referenced
this pull request
Jul 11, 2026
Reconcile the stable-serve-port fix with main after #35272 (in-process memory channel) was reverted by #35670, which restored TCP loopback and brought back the ephemeral-port storage-partition problem this PR fixes. Only conflict was the test-module `use super::` list: keep both the stable-port helpers (this branch) and `should_show_native_error_dialog` plus its three tests (main). The port allocation call site now feeds the stable port into the restored TCP-loopback `DENO_SERVE_ADDRESS` setup. Co-Authored-By: Divy Srivastava <me@littledivy.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #35272 (
perf(desktop): serve over in-process memory channel instead of TCP loopback).That PR replaced the
deno desktopTCP loopback serve path with an in-processmemory:transport (ext/netMemoryListener,ext/httpDENO_SERVE_ADDRESS=memory:override, and anapp://scheme bridge incli/rt_desktop). It caused regressions, so this restores the prior TCP-loopback behavior.What this restores
deno desktopserves on a random TCP loopback port and navigates the webview tohttp://127.0.0.1:PORT(waits for a real HTTP response before navigating).ext/netmemorytransport (memory.rs,op_net_listen_memory,listen({ transport: "memory" }),MemoryStreamResource).ext/httpmemory:<name>DENO_SERVE_ADDRESSoverride.cli/rt_desktop/scheme_bridge.rsand theapp://navigation.Conflict resolution
Only
cli/rt_desktop/lib.rsneeded manual resolution — the window-reveal fix from #35620 (hidden bootstrap window revealed on first paint +show()fallback) landed on top of the memory-channel navigate loop. This revert keeps that fix: the navigate loop is restored to TCP wait +navigate(&url)while preserving theon_page_loadreveal and the idempotentshow()fallback.Verification
cargo checkpasses fordeno_net,deno_http, anddenort_desktop.