Repository navigation
skills: integrate later audit lessons - #23
Conversation
Reconcile fifteen post-PR22 Rust studies against their existing owners. Correct broad buffer, blocking, caching, gate and compatibility guidance; preserve claim limits and keep source evidence in the draft PR. The draft coverage ledger leaves later ADR outputs pending because their original text could not be retrieved in this executor.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c8e087bde
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Move compatibility re-export guidance into the structure reference and large generated-change evidence into the pull-request skill. Link their former locations to those owners so both cannot issue different rules. Make the review checklist select evidence by change type, retaining the testing owner's failing-before requirements for behavior changes and bug fixes without imposing those on behavior-preserving refactors. Address the three Codex review findings on PR #23.
## Motivation The recovered October9–12 ADR audits are the remaining source evidence deferred by [#23](#23). Most of their lessons already live in the ADR reconciliation procedure added by [#22](#22): decision acceptance is separate from delivery, slices need their own evidence, inventories need lifecycle placement, and stale claims must be repaired wherever readers encounter them. One useful distinction can be clearer: a feature name is not proof that the shipped design satisfies the decided contract. A different mechanism may preserve the guarantee, leave a real implementation gap, or require an explicit decision revision. This draft makes that comparison explicit without prescribing the historical proposal as the correct design. ## Solution 1. `8a72865`: amend the existing ADR scope-reconciliation paragraph to compare promised guarantees and distinguish an implementation gap from a decision needing explicit revision. 2. `8a72865`: add one Core Rule2 example that links to that owner; keep all historical project detail here. Only two existing documentation files change. This is a narrow clarification, so package/plugin versions remain `0.6.0`; the repository requires bumps for broad changes. No new skill, duplicate audit checklist, workflow, implementation, ADR file or issue is introduced. **Leave this PR as a draft; do not merge without separate approval.** ### Baseline and source access - Based on the actual default `wip` at `572b154685a75892b54d939e1d2d9b0e6fb22477`, the merged #23 tree. Root `AGENTS.md`, the engineering ownership table, ADR, architecture, method and review owners were inspected. No additional applicable `.agents` instructions were present. - No competing open skills PR was found before editing. Earlier skills issues are older Rust research, not a new ADR integration. - Input is the recovered historical report-message evidence supplied with this task. Full thread text was not accessible in this executor; ZIP issue-body attachments remain unavailable. Neither original issue drafts nor publication receipts are claimed inspected. - Read-only public source checks inspected relevant PR metadata and excerpts of the ADR index, runtime ADR, Read-grants design and physical-persistence design at the October12 snapshot. These corroborate the bounded mechanism comparison; they are not a fresh audit of current Nessa. ### Source-to-owner dispositions | Recovered finding family | Disposition | Existing owner / reason | | --- | --- | --- | | 501 linked once with unique identity but absent from lifecycle table | Already covered | ADR inventory structure requires repository-consistent placement and says a stray link is not index coverage. Uniqueness and membership are separate checks already expressed. | | 252 acceptance versus implementation checklist and tracking state | Already covered | ADR scope reconciliation separates accepted decisions, shipped slices, evidence and remaining gates; reader-surface repair includes tracking issues. | | Partial replay, grants, artifacts, pairing and outbound delivery | Already covered | Per-slice evidence and gates; one merged implementation does not establish full scope. | | A proposed Cedar/semantic-record design versus the shipped metadata grant table and durable journal | **Small amendment** | ADR scope reconciliation now requires matching the promised guarantee instead of the feature name and distinguishing implementation gaps from explicit decision revisions. It does not decide which design is right. | | Stale 0008/0009/202/302/392 prose, index/body conflicts and 688/689 status | Already covered | ADR contradiction repair covers header, current prose, tables, checklists, index, README and tracking issue; placement follows the repository convention. | | Persistence mechanics and 27 ordering cases without decision rationale/rejected alternatives | Already covered | ADR template requires the binding constraint, alternatives and reasons; method's decision artifact also includes rejected options. Implementation instructions and reported tests are not newly relabeled as decision history. | | PR715 already addressed replay documentation; avoid filing it again | Already covered | ADR's existing issue/open-PR comparison checks the exact changed sections, not document overlap. No Nessa issue action is taken. | | Repeat-audit baseline/delta and outcome separation | Coverage practice; no additional skill rule | Pin historical revisions and report new/still-open/reconciled findings in this ledger under existing evidence-class rules. A publication failure is not proof inspection never completed. | | Reported publication failures and disabled ADR automation | Reported operational outcome only | No independent automation-state verification, schedule change or publication retry. Rust research state is outside this patch. | ### Recovered-report coverage ledger These are historical findings at the stated revisions, not claims that the defects remain in current Nessa. Repeated themes are counted once as transferable guidance. | Report message | Historical Nessa snapshot | Recovered coverage and disposition | | --- | --- | --- | | October9 · `2a086b87-e13b-43af-a099-4a2f577bcd82` | `4d1b7278cfe633a6c38094f0bcfb45d4d5043af0` | Reported 36 records:23 done/13 todo;326/344 moved done,252 accepted with implementation separately tracked. 0008,202/302,392,501 and persistence-rationale findings map to existing owners; no duplicate replay-doc work. | | October10 · `2d3f1bcd-f54a-4d96-b836-3caa1a19e0b9` | `88f34e4dabdeca46486dfbd5294e0a2a00a0a5fa` |501 membership,715 stale replay index and720 unchecked grants slice are already covered. The proposed-versus-shipped semantic-contract distinction supports the sole amendment; peer738 and persistence rationale remain historical case evidence. | | October11 · `e4ad69af-9798-4d6f-a666-3a3dbb8aad70` | `bae7a073b597285823b92f037d7079cf4522a716` | Reported 38 records:23 done/13 todo/2 root;688/689 still under review after739,744 pairing shipped while748 outbound was not yet merged at this snapshot. Existing lifecycle/slice/revision rules cover these distinctions. | | October12 · `a452f573-d4e0-4663-a720-3970e6313f15` | `07799e6405812a52297c02bac39525ec0315568e` | Reported37 further commits and38 records; grant/artifact/lease work advanced while checklists lagged;392,501 and rationale gaps persisted. Already-covered themes reinforce the narrow clarification. Reported ADR automation disabling is separate from audit completion and Rust research. | Provenance: recovered messages belong to conversation `6aba0796-656c-83e8-a735-49b9ed36b026`. The identifiers preserve source attribution without putting private conversation links into reusable skills. **Unavailable attachments:** issue-body ZIP attachments were not read, so exact unpublished drafts, their complete acceptance language and publication outcomes were not independently reconstructed. **October13–16:** no report messages were found by the recovery; these dates are not counted as inaccessible completed reports. There is no basis here to invent additional audit runs or claim a current Nessa audit. ### Public supporting evidence - At the [October12 runtime ADR, sliceG](https://github.com/nessalabs/nessa-agent/blob/07799e6405812a52297c02bac39525ec0315568e/docs/adr/todo/252-runtime-roles-and-execution-leases.md#implementation-plan), the wording names a Cedar grant. The [same-revision Read-grants design](https://github.com/nessalabs/nessa-agent/blob/07799e6405812a52297c02bac39525ec0315568e/docs/design/read-grants.md#what-this-slice-does-not-do) explicitly distinguishes its metadata table/journal from in-stream semantic records and policy-bundle changes. [#720](nessalabs/nessa-agent#720) is the delivered slice. This is evidence to compare contracts, not proof that every mechanism difference is a defect or that a chosen implementation must be reverted. - The [pinned ADR index](https://github.com/nessalabs/nessa-agent/blob/07799e6405812a52297c02bac39525ec0315568e/docs/adr/README.md) and [#715](nessalabs/nessa-agent#715), [#739](nessalabs/nessa-agent#739) support the historical projection/lifecycle examples; those rules already exist. - [#744](nessalabs/nessa-agent#744) merged at the October11 report's exact snapshot,15:43UTC. [#748](nessalabs/nessa-agent#748) merged later at16:37UTC. “Not yet merged” is a snapshot observation, not a current outbound-delivery defect. - [#652](nessalabs/nessa-agent#652) and its [pinned physical-persistence design](https://github.com/nessalabs/nessa-agent/blob/07799e6405812a52297c02bac39525ec0315568e/docs/design/bounded-physical-persistence.md) support the distinction between implementation mechanics/reported tests and a decision's rationale. This draft makes no new current missing-ADR claim. ### Validation and limits - **Run:** repository-wide local Markdown path and heading-anchor validation:182 links pass (fenced template examples excluded). - **Run:** all six declared skill paths, required frontmatter and agent descriptors checked; package/plugin versions both remain `0.6.0`. - **Run:** `git diff --check`; refreshed `origin/wip` remains at the stated base before publication. - **Run:** author diff review and independent source-to-owner triage, followed by independent review of the final diff and this description. No material blockers, duplicate owner or evidence/coverage overclaims found. - **Read-only source checks:** the public PRs and pinned documents linked above resolved; selected historical excerpts were inspected. This does not establish runtime behavior or an exhaustive current audit. - **Unavailable:** original full thread text in this executor and ZIP issue-body attachments. The supplied recovered-message evidence is distinguished from source excerpts inspected here. - **Not run:** runtime/native tests, historical ordering cases, benchmarks, installed-skill behavioral evaluation or production defect reproduction. No CI workflows or standard checked-in skill validator exist in this repository; the documentation checks above were run locally. No `nessa-agent` files, issues, PRs or schedules were changed; the separate #953 task was untouched. Prior denied issue publications were not retried. No native/runtime tests, ordering cases or historical audit checks were rerun. The change teaches a review distinction; it does not assert a runtime-validated result or repair historical Nessa defects.
Motivation
Saved coding studies after #22 contain useful distinctions that the current skills omit or state too broadly. For example, moving every lock wait to a finite blocking pool can exhaust the very workers needed to release the waits, and clearing a reused output buffer can discard an unsent suffix.
This draft folds transferable lessons into their existing owners, preserving the two core rules and current structure. Rust coverage is complete for the 15 supplied post-PR22 packages; post-October8 ADR coverage remains incomplete because original later audit outputs were unavailable in this executor. No Nessa implementation, upstream repository, or existing issue is changed. Do not merge this draft without further approval.
Solution
8c8e087: refine coding's existing state, lifetime, deadline, retry, settings and performance rules; correct the closed-peer wake rule using skills: refine contracts and ADR evidence #22's review evidence.8c8e087: update Rust-specific ownership, receiver dispatch, layout, buffers, inlining, recursion and blocking advice.8c8e087: amend the testing and architecture owners for consumer execution, protocol framing, exact regressions, cache/publication scope, handoff phases, capability declarations and compatibility.8c8e087: add eight compact core-rule examples and bump package/plugin versions together from0.5.0to0.6.0.1e4cb6c: reconcile ready-triggered review feedback at the owning structure, pull-request and testing rules; replace competing copies with links.Baseline and duplicate check
wip, at264dbfe50e06e109da02e265e0b61003d0868c5d; there is no remote main branch to target.719e8af7032eb2c3d5bd6c1de051d7563a9b0094. Its body, diff, source mapping and review were inspected against current files.AGENTS.md, engineering ownership/process README, and the affected owners. No repository.agentstree or further applicable workspace instructions were present.Coverage ledger: already covered
The inherited ledger supplied for #22 records 27 completed Rust slots September25–October8 (one completed October9 UTC), plus 11 ADR runs September28–October8. Its merged source-to-owner map and current owner text establish the baseline; this change does not claim to re-execute or independently re-audit every earlier report. The failed October2 AM slot has no completed report and is unavailable, rather than an integration omission. #20's earlier corpus is inherited too.
Coverage ledger: reviewed reports and dispositions
All 15 full Rust reports below were read through Library to their returned final line (
has_more=false), together with their integration plans. The report links identify saved provenance; primary PR links support the transferable mechanisms. Exact Library IDs preservethe saved-report identity; their canonical paths are in the supplied inventory. Several studies propose the same correction: each has one detail owner. “Already covered” means present in the inspected baseline, rather than a proposal assumed adopted.
libfile_4e9878da2c1881919a4020b5ac74fab9); BurntSushi/ripgrep#2692, BurntSushi/ripgrep#3501, BurntSushi/ripgrep#2576Arccycles and Cargo executable discovery. Patterns: consumed framing before offset correction.libfile_8c20647b2a1c81918392e7e52ae46b61); tauri-apps/tauri#16222, tauri-apps/tauri#16231, tauri-apps/tauri#16235libfile_d035ff8a81e48191a571d7fac0386c72); zed-industries/zed#65244, zed-industries/zed#65257, zed-industries/zed#65334, zed-industries/zed#65398, zed-industries/zed#65384libfile_ea7c69f5f978819198924802d85c9d3a); bevyengine/bevy#26040, bevyengine/bevy#26042, bevyengine/bevy#25923, bevyengine/bevy#26014libfile_1ab4e2809424819188378f29d8fcf667); denoland/deno#36074, denoland/deno#36736, denoland/deno#36976, denoland/deno#36160, denoland/deno#35698libfile_7d32c84c8214819190853df7710c05fe); pola-rs/polars#29790, pola-rs/polars#29791, pola-rs/polars#29793, pola-rs/polars#29798, pola-rs/polars#29836, pola-rs/polars#29763, pola-rs/polars#29828libfile_743f1346044c8191b517252aa2a1424f); rust-lang/rust#163915, rust-lang/rust#163521, rust-lang/rust#164008, rust-lang/rust#162849, rust-lang/rust#163235, rust-lang/rust#162810libfile_bd087444977c81919d52db2b961efc84); hyperium/hyper#4222, hyperium/hyper#4042, hyperium/hyper#4056, hyperium/hyper#2562, hyperium/hyper#3230libfile_8b66498f177c81918be9ae0ec5db1d3a); serde-rs/serde#2795, serde-rs/serde#2785, serde-rs/serde#2697, serde-rs/serde#2845, serde-rs/serde#2847, serde-rs/serde#2786write_str, guaranteed speedup or mandatory cache.libfile_0cc843f763808191b27526c549fddb79); tokio-rs/tokio#8587, tokio-rs/tokio#8618, tokio-rs/tokio#8371, tokio-rs/tokio#8530, tokio-rs/tokio#8185, tokio-rs/tokio#8603libfile_031e2ffd151c819193f7f57018fe8734); BurntSushi/ripgrep#2626, BurntSushi/ripgrep#2663, BurntSushi/ripgrep#2684, BurntSushi/ripgrep#895, BurntSushi/ripgrep#961, BurntSushi/ripgrep#2610, BurntSushi/ripgrep#3177libfile_eff2545285c08191a33ef4c1984900c8); tauri-apps/tauri#16199, tauri-apps/tauri#16241, tauri-apps/tauri#16240, tauri-apps/tauri#16279, tauri-apps/tauri#14457libfile_c52ae93dc54081919810af9c2635871a); zed-industries/zed#65457, zed-industries/zed#65578, zed-industries/zed#65177, zed-industries/zed#65607libfile_8fa6affc07ac81918e0873a76367e39d); bevyengine/bevy#26090, bevyengine/bevy#26109, bevyengine/bevy#25989, bevyengine/bevy#25653libfile_28721355dc288191a811cccdf5cb6abc); denoland/deno#32789, denoland/deno#35294, denoland/deno#34984, denoland/deno#36697, denoland/deno#35272, denoland/deno#35670, denoland/deno#34446, denoland/deno#36690Coverage ledger: unavailable / deferred ADR evidence
6aba0796-656c-83e8-a735-49b9ed36b026could not be read in this environment. Personal-context retrieval returned “unavailable for this conversation.” This is an evidence gap, not a claim no runs exist.a452f573-d4e0-4663-a720-3970e6313f15). Themes include ADR252 checklist, 688/689 after739, 392 contradiction, 501 index omission, persistence rationale after627/652, and 0008/0009/202/302 inconsistencies. These appear related to existing ADR reconciliation rules, but without the original output/revisions they are not counted as independently verified or newly integrated. Keep pending a bounded source-to-owner comparison.nessa-adr-audit-unpublished.zipis baseline recovery, not proof of later coverage.Precision retained
Validation
0.6.0.git diff --check; clean worktree after commit; refreshedorigin/wipremains at the baseline.Pre-merge review reconciliation
After the user authorized merge, marking this draft ready triggered Codex review of
8c8e087. Three findings identified stale competing rules: structure's categorical re-export ban, pull-request evidence's unqualified large-change claim, and the unconditional failed-before review question.1e4cb6cfixes all three at their existing owners and replaces other locations with links. A fresh independent review of those repairs found no remaining contradiction or blocker; 181 repository Markdown links/anchors, six skill declarations/frontmatter and matching versions pass. This does not add any unpublished ADR coverage.Deliberately not changed
No new standalone project skill/reference, copied research report, source provenance table in always-loaded skill text, or duplicate ADR finding checklist. This draft changes the existing owners and matching versions. The separate
nessa-agent#953task and all unrelated workspace repositories were untouched.