Skip to content

acp_thread: Own canonical tool locations - #65384

Merged
benbrandt merged 2 commits into
mainfrom
benbrandt/acp-tool-locations
Oct 9, 2026
Merged

benbrandt merged 2 commits into
mainfrom
benbrandt/acp-tool-locations

Conversation

@benbrandt

@benbrandt benbrandt commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Replace canonical v1 tool locations with a Zed-owned ToolCallLocation as the next bounded ACP v2 data-model cleanup after #65350.

  • Retain raw PathBuf, line, and item metadata, including relative native paths and absolute protocol paths.
  • Move v1/v2 location fields directly into the canonical model instead of converting v2 locations into v1 wrappers.
  • Compare raw OsStr spelling so component-equivalent path changes replace retained source and invalidate old resolved projections.
  • Keep resolved editor locations as projections and migrate the existing image-output UI consumer.
  • Add focused conversion, raw-equality, and patch/projection regressions, including Unix non-UTF-8 paths.

Release Notes:

  • N/A

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Oct 9, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Oct 9, 2026
@benbrandt
benbrandt marked this pull request as ready for review October 9, 2026 11:39
@benbrandt
benbrandt requested a review from bennetbo October 9, 2026 11:39
@benbrandt
benbrandt added this pull request to the merge queue Oct 9, 2026
Merged via the queue into main with commit e778eec Oct 9, 2026
37 checks passed
@benbrandt
benbrandt deleted the benbrandt/acp-tool-locations branch October 9, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants