Repository navigation
fix(completions): complete script paths for bare deno run in zsh - #36976
Merged
Merged
Conversation
bartlomieju
added a commit
that referenced
this pull request
Oct 21, 2026
) (cherry picked from commit a18ce33)
NetOpWibby
pushed a commit
to theende/ende
that referenced
this pull request
Nov 7, 2026
The zsh script only offered subcommands for the first positional and nothing after a non-subcommand word, so `ende -A ./<TAB>` never completed a script path. The first positional now completes subcommands or files, and the default subcommand's flags are accepted at the root. (cherry picked from commit a18ce33) (cherry picked from commit 2a7f724fb97057cce98dd7c4a628b68320ee3820) Upstream: denoland/deno#36976
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zsh completion script didn't account for the bare
deno [flags] <script>form, which runs the default
runsubcommand. The first positional onlyoffered subcommands, and the
case $line[1]dispatch had no fallback, sodeno -A ./<TAB>anddeno ./<TAB>produced nothing but a beep whiledeno run -A ./<TAB>worked.When the root command has a default subcommand, the first positional now
completes subcommands and files, any other leading word falls back to file
completion, and the default subcommand's visible flags are offered at the root.
Flag specs are rendered through one helper, so subcommand flags also get their
short forms.
Fixes #36959