Repository navigation
agent_servers: Move the legacy ACP adapter into v1 - #65607
Merged
Merged
Conversation
benbrandt
marked this pull request as ready for review
October 14, 2026 19:28
bennetbo
approved these changes
Oct 14, 2026
This was referenced Oct 15, 2026
amirkhakshour
pushed a commit
to SourceShift/zed-mini-ork
that referenced
this pull request
Oct 18, 2026
) - Move `AcpConnection`, its defaults, the v1 builder/capabilities/wire handlers, legacy session/config/MCP operations and session-list implementation into `acp/v1.rs` alongside `acp/v2.rs`. - Keep foreground routing/context, shared session/config data, v2 client ingress, canonical permission/elicitation application, shared terminal-auth construction and error/lifecycle helpers in the root/shared modules. - Keep only the v1 config-setting wire method on the shared config data in `v1.rs`; the shared constructor/state stays in the root. The existing mixed session record is not redesigned in this extraction. - Preserve public paths through root reexports (`AcpConnection`, `AcpSessionList`, `connect`, the Gemini terminal-auth constant and conditional `test_support`). Consumer call sites are unchanged. The shared-runtime test imports the moved private v1 driver directly. - Keep compatibility/ingress tests alongside the legacy harness they exercise; v2 connection/auth tests stay in `v2.rs`. Test names gain the v1 module prefix but their bodies and scheduler behavior are unchanged. ## Review This is a large source relocation, not thousands of new implementation lines. For copy-aware review: ```sh git diff -B -M origin/main...HEAD -- crates/agent_servers/src/acp.rs crates/agent_servers/src/acp/v1.rs crates/agent_servers/src/acp/runtime.rs ``` Git recognizes `v1.rs` as a 93%-similar copy of the old adapter. Review the retained root boundary and the small import/visibility changes rather than re-reviewing unchanged test bodies. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AcpConnection, its defaults, the v1 builder/capabilities/wire handlers, legacy session/config/MCP operations and session-list implementation intoacp/v1.rsalongsideacp/v2.rs.v1.rs; the shared constructor/state stays in the root. The existing mixed session record is not redesigned in this extraction.AcpConnection,AcpSessionList,connect, the Gemini terminal-auth constant and conditionaltest_support). Consumer call sites are unchanged. The shared-runtime test imports the moved private v1 driver directly.v2.rs. Test names gain the v1 module prefix but their bodies and scheduler behavior are unchanged.Review
This is a large source relocation, not thousands of new implementation lines. For copy-aware review:
Git recognizes
v1.rsas a 93%-similar copy of the old adapter. Review the retained root boundary and the small import/visibility changes rather than re-reviewing unchanged test bodies.Release Notes: