Repository navigation
Conversation
Base automatically changed from
benbrandt/acp-shared-client-runtime
to
benbrandt/acp-v2-connection-auth-foundation
October 14, 2026 18:58
Member
Author
|
Replaced by #65607 against main. Both prerequisites have landed; the extraction branch was rebased without source changes (identical stable patch ID). GitHub refuses reopening this PR because its old base branch was deleted, and refuses retargeting while it is closed. Review history is retained here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #65601's reviewed head (
2a522533d423ad). This is the mechanical module-boundary follow-up, not another lifecycle or session-backend change. Retarget after the prerequisite lands; #65601 and #65582 are unchanged.AcpConnection, its defaults, the v1 builder/capabilities/wire handlers, legacy session/config/MCP operations and session-list implementation intoacp/v1.rsalongsideacp/v2.rs.v1.rs; the shared constructor/state stays in the root. The existing mixed session record is not redesigned in this extraction.AcpConnection,AcpSessionList,connect, the Gemini terminal-auth constant and conditionaltest_support). Consumer call sites are unchanged. The shared-runtime test imports the moved private v1 driver directly.v2.rs. Test names gain the v1 module prefix but their bodies and scheduler behavior are unchanged.The root is now 755 lines rather than 10,318. Shared and legacy declaration bodies were compared against a mechanical partition of the original source after rustfmt; they match. Changes beyond relocation are imports/reexports and the two internal visibility adjustments needed by shared ingress and the runtime regression.
Production still negotiates v1. No public type renames, wire/storage changes, session-state redesign, new backend operations or selection changes.
Review
This is a large source relocation, not thousands of new implementation lines. For copy-aware review:
Git recognizes
v1.rsas a 93%-similar copy of the old adapter. Review the retained root boundary and the small import/visibility changes rather than re-reviewing unchanged test bodies.Validation
cargo test -p agent_servers -p acp_thread -p acp_tools -p agent_ui -p agent --lib --locked -- --test-threads=1: 1,679 passed, 11 ignored;agent_serversretains all 102 tests.SEED=200 ITERATIONS=100 cargo test -p agent_servers --lib sdk_ --locked: 25-test SDK group, with GPUI seeds 200–299.SEED=200 ITERATIONS=100 cargo test -p agent_servers --lib shared_runtime --locked: five-test runtime group, with GPUI seeds 200–299.GITHUB_ACTIONS=true ./script/clippy -p acp_thread -p agent_servers -p acp_tools -p agent_ui -p agent -p zed --locked.cargo rustc -p agent_servers --lib --locked -- -D warningsfor the plain production configuration.cargo check -p agent_servers -p acp_thread -p agent_ui --all-targets --features test-support --locked, including consumer/test-support reexports.cargo check -p zed --bins --locked.RUSTDOCFLAGS='-D warnings' cargo doc -p agent_servers --no-deps --locked.Live-agent/UI, E2E execution and local Linux/Windows/remote workflows were not run. README's manual review marker and the local migration plan remain excluded.
Release Notes: