Repository navigation
agent_servers: Add inactive v2 connection and auth foundation - #65582
Merged
Merged
Conversation
bennetbo
approved these changes
Oct 14, 2026
This was referenced Oct 15, 2026
amirkhakshour
pushed a commit
to SourceShift/zed-mini-ork
that referenced
this pull request
Oct 18, 2026
…dustries#65582) Add an unselected `AcpV2Connection` for real SDK v2 initialization and Agent auth, using the existing stdio launcher/logging, consolidated client ingress, terminal-auth task builder and canonical elicitation cleanup. - Retain sent initialization and received capabilities/info/auth methods. Missing auth methods disable login/logout even when `capabilities.auth` exists; advertised methods enable logout. Agent login rejects terminal/unknown methods, and opaque metadata does not authorize terminal execution. - Advertise terminal authentication only when a configured agent invocation is available; reuse the first-class terminal route and its command/argument/environment placement. - Publish auth requests before installing caller-drop cleanup. Cancel using the SDK handle and queue elicitation cleanup by the actual parent RPC ID, without duplicating SDK settlement state or mutating foreground entities from a destructor. - Track caller-owned live RPC IDs in the v2 foreground context before publication, not SDK settlement state. Closed scopes reject new elicitations, including late input from a non-cooperative peer. Success cancels unanswered input but preserves accepted URL entries for completion notifications; cancellation/failure retains broader cleanup. V1 and ingress-only contexts retain their existing behavior. - Retain the foreground owners through cooperative SDK shutdown so a displayed store is settled after EOF or connection destruction. Startup failure/abandonment also reaps the owned child; process-exit diagnostics reuse the existing stderr drain. This type does **not** implement `AgentConnection` and is not selected by the production factory. Existing v1 negotiation and beta behavior remain unchanged. No session creation, config/MCP RPCs, prompt receipts, activity or rollout/fallback selection changes. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an unselected
AcpV2Connectionfor real SDK v2 initialization and Agent auth, using the existing stdio launcher/logging, consolidated client ingress, terminal-auth task builder and canonical elicitation cleanup.capabilities.authexists; advertised methods enable logout. Agent login rejects terminal/unknown methods, and opaque metadata does not authorize terminal execution.This type does not implement
AgentConnectionand is not selected by the production factory. Existing v1 negotiation and beta behavior remain unchanged. No session creation, config/MCP RPCs, prompt receipts, activity or rollout/fallback selection changes.Release Notes: