Repository navigation
Fix roundtrip of flatten externally tagged enum unit variant - #2786
Merged
Merged
Conversation
Mingun
force-pushed
the
serialize-flatten-unit-variant
branch
from
August 3, 2024 12:04
87cf403 to
7fc1636
Compare
Contributor
Author
- deserialization of flatten unit variant is possible
- serialization of such variant gives Err("can only flatten structs and maps (got an enum)")
Mingun
force-pushed
the
serialize-flatten-unit-variant
branch
from
October 25, 2024 15:59
7fc1636 to
c17b139
Compare
oli-obk
reviewed
Dec 26, 2024
This was referenced Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit variant of externally tagged enum can be deserialized when enum is flatten, but cannot be serialized --
sertest failed:This PR fixes this inconsistency