Repository navigation
agent: Skip redundant thread saves while a response streams - #65244
Merged
Merged
Conversation
osiewicz
reviewed
Oct 7, 2026
osiewicz
reviewed
Oct 7, 2026
osiewicz
reviewed
Oct 7, 2026
osiewicz
left a comment
Member
There was a problem hiding this comment.
LGTM sans the submitted comments.
osiewicz
approved these changes
Oct 7, 2026
3 tasks done
|
Great work! |
Member
Author
|
Thanks! This PR only changes how often we save, not what we save. That part hasn't changed, so finished messages get saved right away, and the one that's still streaming lives in memory until it's done. So for your train case, it depends on what happens to that last message:
That second one is a known gap, tracked in #65464. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64823
While the agent replied, every streamed chunk saved the whole thread: serializing it to JSON, compressing it, and rewriting the SQLite row. The streamed text isn't saved until its message completes, so nearly all of these writes were identical.
Now the thread is not saved while a message is streaming, unless a message has completed or a setting, the title, or the draft prompt changed since the last save.
Measured on a 16.6 MB thread (0.76 MB compressed) while the agent replied to one prompt for ~40s:
Before:
Initial:

Streaming:

After:
Initial:

Streaming:

Release Notes: