Skip to content

fix: store tauri menu items in Menu - #16231

Merged
Legend-Master merged 2 commits into
devfrom
store-tauri-menu-items
Oct 8, 2026
Merged

Legend-Master merged 2 commits into
devfrom
store-tauri-menu-items

Conversation

@Legend-Master

@Legend-Master Legend-Master commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Fix #16229, regession from #15679

MenuItemInner was dropped instead of kept inside the Menu that only the inner muda MenuItem was kept, this means we dropped the javascript channel straight away after giving a MenuItem to the Menu

I'm honestly not the happiest about this solution but it's all what I could think of right now.

@Legend-Master Legend-Master changed the title fix: store tauri mene items in Menu fix: store tauri menu items in Menu Oct 8, 2026
@Legend-Master
Legend-Master marked this pull request as ready for review October 8, 2026 08:09
@Legend-Master
Legend-Master requested a review from a team as a code owner October 8, 2026 08:09
@FabianLars

Copy link
Copy Markdown
Member

all that just because we wanted to clean up the channels 😂

@FabianLars FabianLars left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested review - because that worked so good last time :P

@Legend-Master

Copy link
Copy Markdown
Contributor Author

😂 feel like there's so many bugs around the ref counting menu things

@Legend-Master
Legend-Master merged commit 7c24f5b into dev Oct 8, 2026
27 checks passed
@Legend-Master
Legend-Master deleted the store-tauri-menu-items branch October 8, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Menu creation can no longer take MenuItemOptions with action directly, and memory leak if did so

2 participants