Repository navigation
fix: store tauri menu items in Menu - #16231
Merged
Merged
Conversation
MenuMenu
Legend-Master
marked this pull request as ready for review
October 8, 2026 08:09
Member
|
all that just because we wanted to clean up the channels 😂 |
FabianLars
approved these changes
Oct 8, 2026
FabianLars
left a comment
Member
There was a problem hiding this comment.
untested review - because that worked so good last time :P
Contributor
Author
|
😂 feel like there's so many bugs around the ref counting menu things |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #16229, regession from #15679
MenuItemInnerwas dropped instead of kept inside theMenuthat only the inner mudaMenuItemwas kept, this means we dropped the javascript channel straight away after giving aMenuItemto theMenuI'm honestly not the happiest about this solution but it's all what I could think of right now.