Skip to content

[Scheduled Run] Localized resource files from OneLocBuild - #4607

Merged
paulmedynski merged 1 commit into
mainfrom
dev/automation/onelocbuild-20260827-200259
Aug 31, 2026
Merged

paulmedynski merged 1 commit into
mainfrom
dev/automation/onelocbuild-20260827-200259

Conversation

@cheenamalhotra

Copy link
Copy Markdown
Member

Automated PR created from the OneLocBuild scheduled pipeline run.

Contains updated localized Strings.*.resx resource files.

Copilot AI balanced review requested due to automatic review settings August 27, 2026 20:03
@cheenamalhotra
cheenamalhotra requested a review from a team as a code owner August 27, 2026 20:03
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Aug 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Localizes two ServerCertificate error messages across 13 resource files.

Changes:

  • Adds translations for certificate-file loading failures.
  • Adds translations for unavailable server certificates.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Strings.zh-Hant.resx Traditional Chinese translations
Strings.zh-Hans.resx Simplified Chinese translations
Strings.tr.resx Turkish translations
Strings.ru.resx Russian translations
Strings.pt-BR.resx Brazilian Portuguese translations
Strings.pl.resx Polish translations
Strings.ko.resx Korean translations
Strings.ja.resx Japanese translations
Strings.it.resx Italian translations
Strings.fr.resx French translations
Strings.es.resx Spanish translations
Strings.de.resx German translations
Strings.cs.resx Czech translations

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/Microsoft.Data.SqlClient/src/Resources/Strings.it.resx
@paulmedynski
paulmedynski enabled auto-merge (squash) August 31, 2026 13:58
@paulmedynski
paulmedynski merged commit 9449c98 into main Aug 31, 2026
363 of 370 checks passed
@paulmedynski
paulmedynski deleted the dev/automation/onelocbuild-20260827-200259 branch August 31, 2026 16:33
@github-project-automation github-project-automation Bot moved this from In review to Done in SqlClient Board Aug 31, 2026
priyankatiwari08 added a commit that referenced this pull request Sep 2, 2026
* Add idempotent localization PR script to stop duplicate PRs

The scheduled Localization-CI pipeline opens a brand-new GitHub PR on
every run because its inline "Open PR on GitHub" step pushes a
timestamped branch (dev/automation/onelocbuild-<yyyyMMdd-HHmmss>) and
never checks whether an equivalent PR is already open. Four
byte-for-byte identical PRs (#4607, #4612, #4613, #4614) accumulated as
a result.

Add eng/pipelines/scripts/Open-LocalizationPr.ps1 as a reusable,
idempotent replacement for that inline step:

- Uses a stable branch name, rebuilt from the base branch each run, so
  no timestamped branch proliferation and no commit accumulation.
- Exits without pushing or calling the GitHub API when the localized
  resources are identical to the base branch.
- Skips the force-push when the remote branch already holds the exact
  same tree on top of the same base.
- Reuses an already-open pull request (PATCH) instead of opening a
  second one, and otherwise opens exactly one new PR.

Includes Pester v5 tests covering the de-duplication contract with git
and Invoke-RestMethod mocked.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: cb6c5b07-fb77-43bc-a4aa-a9d39aa04438

* Add -DryRun switch to Open-LocalizationPr.ps1

Allows validating the pipeline wiring (paths, token scopes, OneLocBuild
output, existing-PR lookup) from a feature branch without pushing a
branch or creating/updating a pull request in the public repository.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: cb6c5b07-fb77-43bc-a4aa-a9d39aa04438

* Address review feedback on Open-LocalizationPr

- Authenticate git via GIT_CONFIG_* environment config instead of embedding
  the token in the remote URL, so it never reaches .git/config, a process
  command line, or Invoke-Git exception messages. Cleared in the finally block.
- Read GitHub error bodies from $_.ErrorDetails first, since PowerShell 7
  exposes an HttpResponseMessage with no GetResponseStream(); keep the stream
  path as a Windows PowerShell fallback so 4xx bodies are no longer dropped.
- Replace the unconditional force-push with --force-with-lease pinned to the
  remote SHA observed earlier in the run, so an overlapping run fails instead
  of discarding a concurrent localization result.

Adds 4 tests (17 total, all passing).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: cb6c5b07-fb77-43bc-a4aa-a9d39aa04438

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: cb6c5b07-fb77-43bc-a4aa-a9d39aa04438
Copilot AI mentioned this pull request Sep 18, 2026
4 tasks done
paulmedynski added a commit that referenced this pull request Sep 18, 2026
Addresses PR #4699 review feedback from cheenamalhotra and Copilot.

The OneLocBuild resource refreshes (#4607, #4645, #4651) were backported to
release/7.0 before 7.0.3 via #4634, #4649, and #4669, so 7.0.3 users already
have them and they do not belong in "Cumulative Changes Since 7.0.3".

Routine localized-string refreshes also carry no actionable information for
consumers, and 7.0.3 shipped the same backports without documenting them.
Removing the entries from the GA delta, the cumulative section, and the
changelog keeps the 7.1.0 notes consistent with that precedent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants