[Scheduled Run] Localized resource files from OneLocBuild - #4614
Closed
cheenamalhotra wants to merge 1 commit into
Closed
cheenamalhotra wants to merge 1 commit into
cheenamalhotra wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Localizes two certificate-related diagnostics previously left in English.
Changes:
- Adds translations for certificate file loading/parsing failures.
- Adds translations for unavailable server certificates.
File summaries
| File | Description |
|---|---|
Strings.zh-Hant.resx |
Traditional Chinese translations |
Strings.zh-Hans.resx |
Simplified Chinese translations |
Strings.tr.resx |
Turkish translations |
Strings.ru.resx |
Russian translations |
Strings.pt-BR.resx |
Brazilian Portuguese translations |
Strings.pl.resx |
Polish translations |
Strings.ko.resx |
Korean translations |
Strings.ja.resx |
Japanese translations |
Strings.it.resx |
Italian translations; one malformed quote |
Strings.fr.resx |
French translations |
Strings.es.resx |
Spanish translations |
Strings.de.resx |
German translations |
Strings.cs.resx |
Czech translations |
Review details
- Files reviewed: 13/13 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| </data> | ||
| <data name="SQL_ServerCertificateFileLoadFailed" xml:space="preserve"> | ||
| <value>The certificate file specified by the 'ServerCertificate' option could not be loaded or parsed: '{0}'.</value> | ||
| <value>Non è possibile caricare o analizzare il file del certificato specificato dall'opzione 'ServerCertificate: '{0}'.</value> |
4 of 7 tasks
priyankatiwari08
approved these changes
Aug 31, 2026
Contributor
There was a problem hiding this comment.
Structurally sound — 705 <data> entries, key set/ordering/encoding unchanged, placeholders correct across all 13 locales. No code or API change.
Superseded. Identical tree to #4612, #4613 and #4607. #4607 merged, so this is redundant — closing. Duplicate cause fixed in #4615.
Two localization defects worth routing upstream to the vendor (hand-edits here get overwritten on the next drop):
- pt-BR — doubled apostrophes (
''ServerCertificate'') render literally. Doubling is an ICU/MessageFormatescape, not a .NET one;string.Formatonly escapes{and}. - it-IT —
SQL_ServerCertificateFileLoadFailedopens a quote beforeServerCertificateand never closes it.
This was referenced Aug 31, 2026
Contributor
priyankatiwari08
added a commit
that referenced
this pull request
Sep 2, 2026
* Add idempotent localization PR script to stop duplicate PRs The scheduled Localization-CI pipeline opens a brand-new GitHub PR on every run because its inline "Open PR on GitHub" step pushes a timestamped branch (dev/automation/onelocbuild-<yyyyMMdd-HHmmss>) and never checks whether an equivalent PR is already open. Four byte-for-byte identical PRs (#4607, #4612, #4613, #4614) accumulated as a result. Add eng/pipelines/scripts/Open-LocalizationPr.ps1 as a reusable, idempotent replacement for that inline step: - Uses a stable branch name, rebuilt from the base branch each run, so no timestamped branch proliferation and no commit accumulation. - Exits without pushing or calling the GitHub API when the localized resources are identical to the base branch. - Skips the force-push when the remote branch already holds the exact same tree on top of the same base. - Reuses an already-open pull request (PATCH) instead of opening a second one, and otherwise opens exactly one new PR. Includes Pester v5 tests covering the de-duplication contract with git and Invoke-RestMethod mocked. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: cb6c5b07-fb77-43bc-a4aa-a9d39aa04438 * Add -DryRun switch to Open-LocalizationPr.ps1 Allows validating the pipeline wiring (paths, token scopes, OneLocBuild output, existing-PR lookup) from a feature branch without pushing a branch or creating/updating a pull request in the public repository. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: cb6c5b07-fb77-43bc-a4aa-a9d39aa04438 * Address review feedback on Open-LocalizationPr - Authenticate git via GIT_CONFIG_* environment config instead of embedding the token in the remote URL, so it never reaches .git/config, a process command line, or Invoke-Git exception messages. Cleared in the finally block. - Read GitHub error bodies from $_.ErrorDetails first, since PowerShell 7 exposes an HttpResponseMessage with no GetResponseStream(); keep the stream path as a Windows PowerShell fallback so 4xx bodies are no longer dropped. - Replace the unconditional force-push with --force-with-lease pinned to the remote SHA observed earlier in the run, so an overlapping run fails instead of discarding a concurrent localization result. Adds 4 tests (17 total, all passing). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: cb6c5b07-fb77-43bc-a4aa-a9d39aa04438 --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: cb6c5b07-fb77-43bc-a4aa-a9d39aa04438
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR created from the OneLocBuild scheduled pipeline run.
Contains updated localized
Strings.*.resxresource files.