Skip to content

[release/8.0] Remove Publish-Build-Assets references - #17253

Merged
missymessa merged 4 commits into
dotnet:release/8.0from
missymessa:missymessa/vg20-cleanup-release-8.0
Aug 6, 2026
Merged

missymessa merged 4 commits into
dotnet:release/8.0from
missymessa:missymessa/vg20-cleanup-release-8.0

Conversation

@missymessa

Copy link
Copy Markdown
Member

Backport of #17247 for release/8.0.

Removes all remaining Publish-Build-Assets variable-group imports from the release-specific Arcade templates and validation pipeline. This is part of the VG20 least-privilege cleanup tracked by DNCENG 10812.

Backport the VG20 cleanup without reintroducing files absent from this release branch.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8d5c9824-be94-4260-a72c-605d0ce1294d
Copilot AI review requested due to automatic review settings August 5, 2026 17:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This backport removes remaining imports of the Publish-Build-Assets Azure DevOps variable group from release/8.0 pipeline YAML templates and the SDK validation pipeline, aligning with the least-privilege VG20 cleanup described in the PR metadata.

Changes:

  • Removed - group: Publish-Build-Assets from eng/validate-sdk.yml.
  • Removed Publish-Build-Assets group imports from shared and *-official post-build variable templates.
  • Removed Publish-Build-Assets group imports from shared and *-official CodeQL job templates and publish-build-assets job templates.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
eng/validate-sdk.yml Drops Publish-Build-Assets variable group import from the SDK validation pipeline job variables.
eng/common/templates/post-build/common-variables.yml Removes Publish-Build-Assets import from shared post-build variables template.
eng/common/templates/jobs/codeql-build.yml Removes Publish-Build-Assets import from shared CodeQL build template variables.
eng/common/templates/job/publish-build-assets.yml Removes Publish-Build-Assets import from shared publish-build-assets job template variables.
eng/common/templates-official/post-build/common-variables.yml Removes Publish-Build-Assets import from official post-build variables template.
eng/common/templates-official/jobs/codeql-build.yml Removes Publish-Build-Assets import from official CodeQL build template variables.
eng/common/templates-official/job/publish-build-assets.yml Removes Publish-Build-Assets import from official publish-build-assets job template variables.
eng/common-variables.yml Removes Publish-Build-Assets import (and associated comment) from common internal-build variables.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@missymessa
missymessa requested a review from mmitche August 5, 2026 18:38
Keep the existing update-packagesource.ps1 authentication functional while avoiding the broad Publish-Build-Assets variable group.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8d5c9824-be94-4260-a72c-605d0ce1294d
Copilot AI review requested due to automatic review settings August 5, 2026 18:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

Suppressed comments (1)

eng/validate-sdk.yml:25

  • The variables parameter is a YAML sequence, but the list items are currently aligned with variables: rather than nested under it. This style is inconsistent with other templates in the repo and risks the job template invocation being parsed incorrectly.
    variables:
    - group: Arcade-Promotion-GitHub
    - _BuildConfig: ${{ parameters.buildConfig }}
    - _BuildArgs: ${{ parameters.buildArgs }}
    - _ValidateBlobFeedUrl: ${{ parameters.validateBlobFeedUrl }}

@missymessa
missymessa enabled auto-merge (squash) August 5, 2026 19:03
Remove stale variable-group imports after the group's only secret was retired from Arcade's vault manifest.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8d5c9824-be94-4260-a72c-605d0ce1294d
Copilot AI review requested due to automatic review settings August 6, 2026 00:25
@missymessa

Copy link
Copy Markdown
Member Author

Added the release/8.0 backport of #17259 in commit 47f8257. It removes the remaining AzureDevOps-Artifact-Feeds-Pats imports from both publishing-template copies so the branch no longer downloads the retired dn-bot-all-orgs-artifact-feeds-rw secret.

-- GitHub Copilot CLI (posted on behalf of @missymessa)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

@missymessa
missymessa merged commit dcc22d2 into dotnet:release/8.0 Aug 6, 2026
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants