Repository navigation
Remove unused artifact feed PAT variable group imports - #17259
Merged
missymessa merged 1 commit intoAug 6, 2026
Merged
Conversation
The dn-bot-all-orgs-artifact-feeds-rw secret was removed from the Arcade vault manifest, but publishing templates still imported its variable group. Remove the stale imports so Key Vault download no longer fails when Secret Manager disables the retired secret. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8d5c9824-be94-4260-a72c-605d0ce1294d
Contributor
There was a problem hiding this comment.
Pull request overview
Removes imports of a retired Azure DevOps variable group from Arcade publishing templates to prevent Build Promotion jobs from failing during Key Vault variable download after the underlying secret was disabled (the PAT is no longer used).
Changes:
- Removed
AzureDevOps-Artifact-Feeds-Patsvariable group import from the v3 publishing pipeline. - Removed
AzureDevOps-Artifact-Feeds-Patsvariable group import from thepublish-build-assetsjob template.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
eng/publishing/v3/publish.yml |
Drops the stale variable-group import from the v3 publishing stage variables. |
eng/common/core-templates/job/publish-build-assets.yml |
Drops the stale variable-group import from the publish-build-assets job variables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mmitche
approved these changes
Aug 5, 2026
mmitche
approved these changes
Aug 5, 2026
This was referenced Aug 6, 2026
missymessa
changed the title
rainersigwald
added a commit
to dotnet/msbuild
that referenced
this pull request
Aug 16, 2026
Fix the official build by removing this group that should no longer be needed after dotnet/arcade#17245. Similar to dotnet/arcade#17259. Exp job was an easy test and got past the failure point: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=14979069 --------- Copilot-Session: f3daa6dc-c4da-488a-afcf-37b45c444e01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dn-bot-all-orgs-artifact-feeds-rwsecret was removed from Arcade's vault manifest in #17245, but two publishing templates still imported the one-secretAzureDevOps-Artifact-Feeds-Patsvariable group. Secret Manager subsequently disabled the secret, causing Build Promotion jobs to fail while downloading Key Vault variables even though the PAT is no longer used.This removes the stale imports from:
eng/publishing/v3/publish.ymleng/common/core-templates/job/publish-build-assets.ymlThe latest secret version was temporarily re-enabled to restore existing promotions until this change merges and propagates.
Related: #17245
Tracking: https://dev.azure.com/dnceng/internal/_workitems/edit/10812