This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
Fix unquoted path parameters in Microsoft.NET.Sdk.IL.targets - #27704
Merged
Merged
Conversation
This fixes issues when running build.cmd in dotnet/corefx when there are spaces on the path. Fixes #27699
|
Thanks! When you manually patch your machine with this file, does it successfully build corefx for you in your path with spaces? |
Author
|
Yeah it does. Basically that's how I've debugged it and found these issues. |
jkoritzinsky
approved these changes
Nov 6, 2019
|
Thank you for your contribution. As announced in dotnet/coreclr#27549 this repository will be moving to dotnet/runtime on November 13. If you would like to continue working on this PR after this date, the easiest way to move the change to dotnet/runtime is:
|
Author
|
@maryamariyan is there a chance it will get merged before then? :) |
Member
|
Thank you! |
stephentoub
added a commit
that referenced
this pull request
Nov 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27699