Repository navigation
Switch to .Internal insertion package for .NET Core - #1748
Merged
dsplaisted merged 28 commits intoApr 25, 2019
Merged
Conversation
…0190423.10 - Microsoft.NETCore.App - 3.0.0-preview6-27623-10 - NETStandard.Library.Ref - 2.1.0-preview6-27623-10 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27623-10
…0190423.12 - Microsoft.NETCore.App - 3.0.0-preview6-27623-12 - NETStandard.Library.Ref - 2.1.0-preview6-27623-12 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27623-12
…0190423.13 - Microsoft.NETCore.App - 3.0.0-preview6-27623-13 - NETStandard.Library.Ref - 2.1.0-preview6-27623-13 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27623-13
…0190423.14 - Microsoft.NETCore.App - 3.0.0-preview6-27623-14 - NETStandard.Library.Ref - 2.1.0-preview6-27623-14 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27623-14
…0190423.15 - Microsoft.NETCore.App - 3.0.0-preview6-27623-15 - NETStandard.Library.Ref - 2.1.0-preview6-27623-15 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27623-15
…0190423.16 - Microsoft.NETCore.App - 3.0.0-preview6-27623-16 - NETStandard.Library.Ref - 2.1.0-preview6-27623-16 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27623-16
…0190423.17 - Microsoft.NETCore.App - 3.0.0-preview6-27623-17 - NETStandard.Library.Ref - 2.1.0-preview6-27623-17 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27623-17
…0190423.18 - Microsoft.NETCore.App - 3.0.0-preview6-27623-18 - NETStandard.Library.Ref - 2.1.0-preview6-27623-18 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27623-18
…0190423.20 - Microsoft.NETCore.App - 3.0.0-preview6-27623-20 - NETStandard.Library.Ref - 2.1.0-preview6-27623-20 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27623-20
…0190423.21 - Microsoft.NETCore.App - 3.0.0-preview6-27623-21 - NETStandard.Library.Ref - 2.1.0-preview6-27623-21 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27623-21
…0190424.02 - Microsoft.NETCore.App - 3.0.0-preview6-27624-02 - NETStandard.Library.Ref - 2.1.0-preview6-27624-02 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27624-02
…0190424.03 - Microsoft.NETCore.App - 3.0.0-preview6-27624-03 - NETStandard.Library.Ref - 2.1.0-preview6-27624-03 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27624-03
…0190424.04 - Microsoft.NETCore.App - 3.0.0-preview6-27624-04 - NETStandard.Library.Ref - 2.1.0-preview6-27624-04 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27624-04
…0190424.05 - Microsoft.NETCore.App - 3.0.0-preview6-27624-05 - NETStandard.Library.Ref - 2.1.0-preview6-27624-05 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27624-05
…0190424.06 - Microsoft.NETCore.App - 3.0.0-preview6-27624-06 - NETStandard.Library.Ref - 2.1.0-preview6-27624-06 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27624-06
…0190424.09 - Microsoft.NETCore.App - 3.0.0-preview6-27624-09 - NETStandard.Library.Ref - 2.1.0-preview6-27624-09 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27624-09
…0190424.12 - Microsoft.NETCore.App - 3.0.0-preview6-27624-12 - NETStandard.Library.Ref - 2.1.0-preview6-27624-12 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27624-12
…0190424.13 - Microsoft.NETCore.App - 3.0.0-preview6-27624-13 - NETStandard.Library.Ref - 2.1.0-preview6-27624-13 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27624-13
…0190424.14 - Microsoft.NETCore.App - 3.0.0-preview6-27624-14 - NETStandard.Library.Ref - 2.1.0-preview6-27624-14 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27624-14
…0190424.15 - Microsoft.NETCore.App - 3.0.0-preview6-27624-15 - NETStandard.Library.Ref - 2.1.0-preview6-27624-15 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27624-15
…0190424.16 - Microsoft.NETCore.App - 3.0.0-preview6-27624-16 - NETStandard.Library.Ref - 2.1.0-preview6-27624-16 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27624-16
…0190424.18 - Microsoft.NETCore.App - 3.0.0-preview6-27624-18 - NETStandard.Library.Ref - 2.1.0-preview6-27624-18 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27624-18
…0190425.01 - Microsoft.NETCore.App - 3.0.0-preview6-27625-01 - NETStandard.Library.Ref - 2.1.0-preview6-27625-01 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27625-01
…0190425.02 - Microsoft.NETCore.App - 3.0.0-preview6-27625-02 - NETStandard.Library.Ref - 2.1.0-preview6-27625-02 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27625-02
…0190425.03 - Microsoft.NETCore.App - 3.0.0-preview6-27625-03 - NETStandard.Library.Ref - 2.1.0-preview6-27625-03 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27625-03
…0190425.04 - Microsoft.NETCore.App - 3.0.0-preview6-27625-04 - NETStandard.Library.Ref - 2.1.0-preview6-27625-04 - Microsoft.WindowsDesktop.App - 3.0.0-preview6-27625-04
Member
No, they'd need Version.Details.xml entries to flow like that. I think it makes sense here to chain this together like what's being done for the host resolver--the only reason I know not to is if you expect the versions to diverge: <MicrosoftNETCoreDotNetHostResolverPackageVersion>$(MicrosoftNETCoreAppPackageVersion)</MicrosoftNETCoreDotNetHostResolverPackageVersion> |
…ET Core package version
wli3
self-requested a review
April 25, 2019 16:59
wli3
approved these changes
Apr 25, 2019
dagood
approved these changes
Apr 25, 2019
dagood
left a comment
dagood
left a comment
Member
There was a problem hiding this comment.
LGTM, I expect dotnet/core-setup#6096 to break this again though because of the .Internal suffix added for the runtime packages here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React to changes in dotnet/core-setup#5893: Switch to Microsoft.NETCore.App.Internal
Includes version updates from #1712, and additional changes to switch to the .Internal package.
@dagood @mmitche Are the new
MicrosoftNETCoreAppInternalPackageVersionandMicrosoftNETCoreDotNetAppHostPackageVersionproperties set up so that they will be updated through the dependency flow?