Skip to content

[Candidate] Fix Build failure in MauiBlazorWebView DeviceTests - #37669

Merged
kubaflo merged 2 commits into
dotnet:inflight/candidatefrom
Dhivya-SF4094:fix-buildFailure_PR-37393
Aug 20, 2026
Merged

kubaflo merged 2 commits into
dotnet:inflight/candidatefrom
Dhivya-SF4094:fix-buildFailure_PR-37393

Conversation

@Dhivya-SF4094

Copy link
Copy Markdown
Contributor

Root Cause

BlazorWebViewTests.Startup.cs uses nullable reference annotations (?), but the project does not enable nullable annotations. This caused CS8632 errors, and warnings are treated as errors.

Cause PR

#35053

Fix

Added #nullable enable at the top of BlazorWebViewTests.Startup.cs.
This follows the existing per-file convention and avoids enabling nullable annotations for the entire project. The Windows device-test build now passes successfully.

@dotnet-policy-service dotnet-policy-service Bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Aug 20, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

@sheiksyedm

Copy link
Copy Markdown
Contributor

/azp run maui-pr-devicetests

@Dhivya-SF4094 Dhivya-SF4094 changed the title [WIP] [Candidate] Fix Build failure in MauiBlazorWebView DeviceTests [Candidate] Fix Build failure in MauiBlazorWebView DeviceTests Aug 20, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@Dhivya-SF4094
Dhivya-SF4094 marked this pull request as ready for review August 20, 2026 12:51
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

@sheiksyedm

Copy link
Copy Markdown
Contributor

/azp run maui-pr-devicetests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@sheiksyedm
sheiksyedm requested a review from kubaflo August 20, 2026 12:58
@kubaflo
kubaflo merged commit e2e98de into dotnet:inflight/candidate Aug 20, 2026
33 of 51 checks passed
@github-actions github-actions Bot added this to the .NET 10 SR11 milestone Aug 20, 2026
kubaflo pushed a commit that referenced this pull request Sep 3, 2026
### Root Cause

BlazorWebViewTests.Startup.cs uses nullable reference annotations (?),
but the project does not enable nullable annotations. This caused CS8632
errors, and warnings are treated as errors.
 
### Cause PR
#35053 

### Fix
Added #nullable enable at the top of BlazorWebViewTests.Startup.cs.
This follows the existing per-file convention and avoids enabling
nullable annotations for the entire project. The Windows device-test
build now passes successfully.
kubaflo pushed a commit that referenced this pull request Sep 4, 2026
### Root Cause

BlazorWebViewTests.Startup.cs uses nullable reference annotations (?),
but the project does not enable nullable annotations. This caused CS8632
errors, and warnings are treated as errors.
 
### Cause PR
#35053 

### Fix
Added #nullable enable at the top of BlazorWebViewTests.Startup.cs.
This follows the existing per-file convention and avoids enabling
nullable annotations for the entire project. The Windows device-test
build now passes successfully.
@kubaflo kubaflo mentioned this pull request Sep 6, 2026
8 tasks
kubaflo pushed a commit that referenced this pull request Sep 7, 2026
### Root Cause

BlazorWebViewTests.Startup.cs uses nullable reference annotations (?),
but the project does not enable nullable annotations. This caused CS8632
errors, and warnings are treated as errors.
 
### Cause PR
#35053 

### Fix
Added #nullable enable at the top of BlazorWebViewTests.Startup.cs.
This follows the existing per-file convention and avoids enabling
nullable annotations for the entire project. The Windows device-test
build now passes successfully.
kubaflo pushed a commit that referenced this pull request Sep 8, 2026
### Root Cause

BlazorWebViewTests.Startup.cs uses nullable reference annotations (?),
but the project does not enable nullable annotations. This caused CS8632
errors, and warnings are treated as errors.
 
### Cause PR
#35053 

### Fix
Added #nullable enable at the top of BlazorWebViewTests.Startup.cs.
This follows the existing per-file convention and avoids enabling
nullable annotations for the entire project. The Windows device-test
build now passes successfully.
kubaflo pushed a commit that referenced this pull request Sep 9, 2026
### Root Cause

BlazorWebViewTests.Startup.cs uses nullable reference annotations (?),
but the project does not enable nullable annotations. This caused CS8632
errors, and warnings are treated as errors.
 
### Cause PR
#35053 

### Fix
Added #nullable enable at the top of BlazorWebViewTests.Startup.cs.
This follows the existing per-file convention and avoids enabling
nullable annotations for the entire project. The Windows device-test
build now passes successfully.
kubaflo added a commit that referenced this pull request Sep 11, 2026
<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

## What's Coming

This draft promotes the current `inflight/candidate` contents into
`main` for the .NET 10 SR11 (`10.0.110`) candidate cycle.

## Candidate Snapshot

- Initial source: `inflight/current`, followed by candidate-specific
stabilization and approved backports
- Rebased onto `main`:
[`b96aa036`](b96aa03)
- Current candidate head:
[`b643a7e3`](b643a7e)
- Final candidate commits relative to `main`: [111
commits](b96aa03...inflight/candidate)
- Rebase accounting: all 111 pre-rebase commits map exactly to 111
rebased commits, with no modified, dropped, or added patches
- Patch version: `110`
- PR #37033 remains intentionally excluded because it merged into
`inflight/current` after the initial candidate cut.

## Stabilization Since the Initial Cut

- #37669 fixes the MauiBlazorWebView device-test build.
- #37672 reverts unstable iOS and Mac Catalyst leak tests.
- #37810 reverts the iOS wrapped-scroll-content large-title change.
- #37837 completes iOS `ScrollView` requests inside collapsed branches.
- #37438 updates the first set of candidate test failures.
- #38021 fixes the Windows `ContentPresenter` device-test regression;
its patch is now supplied by `main`.
- #38096 reverts the Accelerometer weak-event change.
- #38126 backports the BlazorWebView and HybridWebView fixes.
- #38028 updates the remaining candidate test failures and stale iOS
snapshots.

## Rebase Validation

- [x] Commit accounting: 111 exact mappings with no modified, dropped,
or added patches
- [x] Independent reference merge and rebased branch have the identical
tree ID `3e10281363c889cbafd4de790911efb0ae365e2a`
- [x] BuildTasks succeeds with 0 warnings and 0 errors across the
restored Android, iOS, Mac Catalyst, and .NET targets
- [x] All 39 focused `ScrollViewUnitTests` pass
- [x] No merge commits, conflict markers, or new whitespace warnings;
the 26 existing whitespace warnings remain unchanged
- [ ] Post-rebase `maui-pr`, `maui-pr-devicetests`, and
`maui-pr-uitests` runs complete
- [ ] Candidate-only build and test failures triaged
- [ ] Release-readiness assessment completed

This PR remains a draft while candidate validation and stabilization
continue.

Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com>
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 20, 2026

This branch was previously deployed

1 inactive deployment
copilot-pat-pool — eae9fd74 Deployed Aug 20, 2026 by Dhivya-SF4094 via conclusion #1440
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants