Skip to content

Revert "[iOS] NavigationPage: Fix large-title collapse for wrapped scroll content (#36511)" - #37810

Merged
kubaflo merged 1 commit into
dotnet:inflight/candidatefrom
HarishwaranVijayakumar:revert-36511-large-title-proxy
Aug 25, 2026
Merged

kubaflo merged 1 commit into
dotnet:inflight/candidatefrom
HarishwaranVijayakumar:revert-36511-large-title-proxy

Conversation

@HarishwaranVijayakumar

Copy link
Copy Markdown
Contributor

Description

This reverts #36511. The Issue33037NonShell UI tests added by that PR are unstable on iOS 26.5, while the proxy-based implementation is being reconsidered in #37548. Reverting avoids shipping the current implementation while that work continues.

Why revert

  • Five scenarios fail in grouped iOS 26.5 runs despite passing individually and on iOS 26.3:
    • Issue33037FixedHeaderCollectionViewButton
    • Issue33037ShortFixedHeaderCollectionViewButton
    • Issue33037GridScrollViewButton
    • ProgrammaticScrollCollapsesLargeTitle
    • ProgrammaticWebViewScrollCollapsesLargeTitle
  • Restarting the app before each test makes all five pass, showing that the failures are specific to shared test-session state and do not reproduce when the scenarios run independently.
  • Issue33037NonShell_GridScrollView_BeforeScroll also produces an unstable first-paint visual difference.
  • [iOS] Delegate large-title safe area to scroll content #37548 is investigating a replacement for the proxy mechanism and remains in progress.

Changes

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Aug 25, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hey there @@HarishwaranVijayakumar! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

@kubaflo
kubaflo merged commit 1edefae into dotnet:inflight/candidate Aug 25, 2026
9 of 18 checks passed
@github-actions github-actions Bot added this to the .NET 10 SR11 milestone Aug 25, 2026
kubaflo pushed a commit that referenced this pull request Sep 3, 2026
…roll content (#36511)" (#37810)

## Description

This reverts #36511. The `Issue33037NonShell` UI tests added by that PR
are unstable on iOS 26.5, while the proxy-based implementation is being
reconsidered in #37548. Reverting avoids shipping the current
implementation while that work continues.

## Why revert

- Five scenarios fail in grouped iOS 26.5 runs despite passing
individually and on iOS 26.3:
  - `Issue33037FixedHeaderCollectionViewButton`
  - `Issue33037ShortFixedHeaderCollectionViewButton`
  - `Issue33037GridScrollViewButton`
  - `ProgrammaticScrollCollapsesLargeTitle`
  - `ProgrammaticWebViewScrollCollapsesLargeTitle`
- Restarting the app before each test makes all five pass, showing that
the failures are specific to shared test-session state and do not
reproduce when the scenarios run independently.
- `Issue33037NonShell_GridScrollView_BeforeScroll` also produces an
unstable first-paint visual difference.
- #37548 is investigating a replacement for the proxy mechanism and
remains in progress.

## Changes

- Restores `NavigationRenderer.cs` to its pre-#36511 behavior.
- Removes the `Issue33037NonShell` HostApp scenarios and UI tests.
- Removes the nine associated iOS 26 snapshot baselines.
kubaflo pushed a commit that referenced this pull request Sep 4, 2026
…roll content (#36511)" (#37810)

## Description

This reverts #36511. The `Issue33037NonShell` UI tests added by that PR
are unstable on iOS 26.5, while the proxy-based implementation is being
reconsidered in #37548. Reverting avoids shipping the current
implementation while that work continues.

## Why revert

- Five scenarios fail in grouped iOS 26.5 runs despite passing
individually and on iOS 26.3:
  - `Issue33037FixedHeaderCollectionViewButton`
  - `Issue33037ShortFixedHeaderCollectionViewButton`
  - `Issue33037GridScrollViewButton`
  - `ProgrammaticScrollCollapsesLargeTitle`
  - `ProgrammaticWebViewScrollCollapsesLargeTitle`
- Restarting the app before each test makes all five pass, showing that
the failures are specific to shared test-session state and do not
reproduce when the scenarios run independently.
- `Issue33037NonShell_GridScrollView_BeforeScroll` also produces an
unstable first-paint visual difference.
- #37548 is investigating a replacement for the proxy mechanism and
remains in progress.

## Changes

- Restores `NavigationRenderer.cs` to its pre-#36511 behavior.
- Removes the `Issue33037NonShell` HostApp scenarios and UI tests.
- Removes the nine associated iOS 26 snapshot baselines.
@kubaflo kubaflo mentioned this pull request Sep 6, 2026
8 tasks
kubaflo pushed a commit that referenced this pull request Sep 7, 2026
…roll content (#36511)" (#37810)

## Description

This reverts #36511. The `Issue33037NonShell` UI tests added by that PR
are unstable on iOS 26.5, while the proxy-based implementation is being
reconsidered in #37548. Reverting avoids shipping the current
implementation while that work continues.

## Why revert

- Five scenarios fail in grouped iOS 26.5 runs despite passing
individually and on iOS 26.3:
  - `Issue33037FixedHeaderCollectionViewButton`
  - `Issue33037ShortFixedHeaderCollectionViewButton`
  - `Issue33037GridScrollViewButton`
  - `ProgrammaticScrollCollapsesLargeTitle`
  - `ProgrammaticWebViewScrollCollapsesLargeTitle`
- Restarting the app before each test makes all five pass, showing that
the failures are specific to shared test-session state and do not
reproduce when the scenarios run independently.
- `Issue33037NonShell_GridScrollView_BeforeScroll` also produces an
unstable first-paint visual difference.
- #37548 is investigating a replacement for the proxy mechanism and
remains in progress.

## Changes

- Restores `NavigationRenderer.cs` to its pre-#36511 behavior.
- Removes the `Issue33037NonShell` HostApp scenarios and UI tests.
- Removes the nine associated iOS 26 snapshot baselines.
kubaflo pushed a commit that referenced this pull request Sep 8, 2026
…roll content (#36511)" (#37810)

## Description

This reverts #36511. The `Issue33037NonShell` UI tests added by that PR
are unstable on iOS 26.5, while the proxy-based implementation is being
reconsidered in #37548. Reverting avoids shipping the current
implementation while that work continues.

## Why revert

- Five scenarios fail in grouped iOS 26.5 runs despite passing
individually and on iOS 26.3:
  - `Issue33037FixedHeaderCollectionViewButton`
  - `Issue33037ShortFixedHeaderCollectionViewButton`
  - `Issue33037GridScrollViewButton`
  - `ProgrammaticScrollCollapsesLargeTitle`
  - `ProgrammaticWebViewScrollCollapsesLargeTitle`
- Restarting the app before each test makes all five pass, showing that
the failures are specific to shared test-session state and do not
reproduce when the scenarios run independently.
- `Issue33037NonShell_GridScrollView_BeforeScroll` also produces an
unstable first-paint visual difference.
- #37548 is investigating a replacement for the proxy mechanism and
remains in progress.

## Changes

- Restores `NavigationRenderer.cs` to its pre-#36511 behavior.
- Removes the `Issue33037NonShell` HostApp scenarios and UI tests.
- Removes the nine associated iOS 26 snapshot baselines.
kubaflo pushed a commit that referenced this pull request Sep 9, 2026
…roll content (#36511)" (#37810)

## Description

This reverts #36511. The `Issue33037NonShell` UI tests added by that PR
are unstable on iOS 26.5, while the proxy-based implementation is being
reconsidered in #37548. Reverting avoids shipping the current
implementation while that work continues.

## Why revert

- Five scenarios fail in grouped iOS 26.5 runs despite passing
individually and on iOS 26.3:
  - `Issue33037FixedHeaderCollectionViewButton`
  - `Issue33037ShortFixedHeaderCollectionViewButton`
  - `Issue33037GridScrollViewButton`
  - `ProgrammaticScrollCollapsesLargeTitle`
  - `ProgrammaticWebViewScrollCollapsesLargeTitle`
- Restarting the app before each test makes all five pass, showing that
the failures are specific to shared test-session state and do not
reproduce when the scenarios run independently.
- `Issue33037NonShell_GridScrollView_BeforeScroll` also produces an
unstable first-paint visual difference.
- #37548 is investigating a replacement for the proxy mechanism and
remains in progress.

## Changes

- Restores `NavigationRenderer.cs` to its pre-#36511 behavior.
- Removes the `Issue33037NonShell` HostApp scenarios and UI tests.
- Removes the nine associated iOS 26 snapshot baselines.
kubaflo added a commit that referenced this pull request Sep 11, 2026
<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

## What's Coming

This draft promotes the current `inflight/candidate` contents into
`main` for the .NET 10 SR11 (`10.0.110`) candidate cycle.

## Candidate Snapshot

- Initial source: `inflight/current`, followed by candidate-specific
stabilization and approved backports
- Rebased onto `main`:
[`b96aa036`](b96aa03)
- Current candidate head:
[`b643a7e3`](b643a7e)
- Final candidate commits relative to `main`: [111
commits](b96aa03...inflight/candidate)
- Rebase accounting: all 111 pre-rebase commits map exactly to 111
rebased commits, with no modified, dropped, or added patches
- Patch version: `110`
- PR #37033 remains intentionally excluded because it merged into
`inflight/current` after the initial candidate cut.

## Stabilization Since the Initial Cut

- #37669 fixes the MauiBlazorWebView device-test build.
- #37672 reverts unstable iOS and Mac Catalyst leak tests.
- #37810 reverts the iOS wrapped-scroll-content large-title change.
- #37837 completes iOS `ScrollView` requests inside collapsed branches.
- #37438 updates the first set of candidate test failures.
- #38021 fixes the Windows `ContentPresenter` device-test regression;
its patch is now supplied by `main`.
- #38096 reverts the Accelerometer weak-event change.
- #38126 backports the BlazorWebView and HybridWebView fixes.
- #38028 updates the remaining candidate test failures and stale iOS
snapshots.

## Rebase Validation

- [x] Commit accounting: 111 exact mappings with no modified, dropped,
or added patches
- [x] Independent reference merge and rebased branch have the identical
tree ID `3e10281363c889cbafd4de790911efb0ae365e2a`
- [x] BuildTasks succeeds with 0 warnings and 0 errors across the
restored Android, iOS, Mac Catalyst, and .NET targets
- [x] All 39 focused `ScrollViewUnitTests` pass
- [x] No merge commits, conflict markers, or new whitespace warnings;
the 26 existing whitespace warnings remain unchanged
- [ ] Post-rebase `maui-pr`, `maui-pr-devicetests`, and
`maui-pr-uitests` runs complete
- [ ] Candidate-only build and test failures triaged
- [ ] Release-readiness assessment completed

This PR remains a draft while candidate validation and stabilization
continue.

Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com>
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 25, 2026

This branch was previously deployed

1 inactive deployment
copilot-pat-pool — dbdd21b3 Deployed Aug 25, 2026 by HarishwaranVijayakumar via conclusion #1522
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-navigationpage community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants