Add --fully-drawn-magic-string option to startup scenario - #2404
Merged
Merged
Conversation
It can be used on iOS to pass in a magic string that the App is expected to log when it is "fully drawn" and we report the time to that event instead of the normal startup events.
LoopedBard3
approved these changes
Apr 29, 2022
LoopedBard3
left a comment
LoopedBard3
left a comment
Member
There was a problem hiding this comment.
LGTM after help message fix, lets get some test runs before merging.
TanayParikh
reviewed
Apr 29, 2022
Member
|
Testing shows that this seems to work and hasn't cause any other problems. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be used on iOS to pass in a magic string that the App is expected to log when it is "fully drawn" and we report the time to that event instead of the normal startup events.