Skip to content

Add --fully-drawn-magic-string option to startup scenario #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LoopedBard3 merged 3 commits into from
May 2, 2022
Merged

Add --fully-drawn-magic-string option to startup scenario #2404

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cdfbde
Add --fully-drawn-magic-string option to startup scenario
akoeplinger Apr 29, 2022
7cd269b
Update help text
akoeplinger Apr 29, 2022
cddf960
Fix type confusion
akoeplinger May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions src/scenarios/shared/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,9 @@ def parseargs(self):
parseonlyparser.add_argument('--package-name', help='Classname (Android) or Bundle ID (iOS) of application', dest='packagename')
parseonlyparser.add_argument('--startup-iterations', help='Startups to run (1+)', type=int, default=10, dest='startupiterations')
parseonlyparser.add_argument('--disable-animations', help='Disable Android device animations, does nothing on iOS.', action='store_true', dest='animationsdisabled')
parseonlyparser.add_argument('--use-fully-drawn-time', help='Use the startup time from reportFullyDrawn for android, and the equivalent for iOS', action='store_true', dest='usefullydrawntime')
parseonlyparser.add_argument('--use-fully-drawn-time', help='Use the startup time from reportFullyDrawn for android, the equivalent for iOS is handled via logging a magic string and passing it to --fully-drawn-magic-string', action='store_true', dest='usefullydrawntime')
parseonlyparser.add_argument('--fully-drawn-extra-delay', help='Set an additional delay time for an Android app to reportFullyDrawn (seconds), not on iOS. This should be greater than the greatest amount of extra time expected between first frame draw and reportFullyDrawn being called. Default = 3 seconds', type=int, default=3, dest='fullyDrawnDelaySecMax')
parseonlyparser.add_argument('--fully-drawn-magic-string', help='Set the magic string that is logged by the app to indicate when the app is fully drawn. Required when using --use-fully-drawn-time on iOS.', type=str, dest='fullyDrawnMagicString')
self.add_common_arguments(parseonlyparser)

# inner loop command
Expand Down Expand Up @@ -152,6 +153,7 @@ def parseargs(self):
self.animationsdisabled = args.animationsdisabled
self.usefullydrawntime = args.usefullydrawntime
self.fullyDrawnDelaySecMax = args.fullyDrawnDelaySecMax
self.fullyDrawnMagicString = args.fullyDrawnMagicString

if args.scenarioname:
self.scenarioname = args.scenarioname
Expand Down Expand Up @@ -776,7 +778,38 @@ def run(self):
timeToFirstDrawEventEndDateTime = datetime.strptime(timeToFirstDrawEventStop['timestamp'], '%Y-%m-%d %H:%M:%S.%f%z')
timeToFirstDrawMilliseconds = (timeToFirstDrawEventEndDateTime - timeToFirstDrawEventStartDateTime).total_seconds() * 1000

totalTimeMilliseconds = timeToMainMilliseconds + timeToFirstDrawMilliseconds
if self.usefullydrawntime:
# grab log event with the magic string in it
logShowMagicStringCmd = [
'log',
'show',
'--predicate', f'(processIdentifier == {app_pid}) && (composedMessage contains "{self.fullyDrawnMagicString}")',
'--info',
'--style', 'ndjson',
logarchive_filename,
]
logShowMagicStringCmd = RunCommand(logShowMagicStringCmd, verbose=True)
logShowMagicStringCmd.run()

magicStringEvent = ''
for line in logShowMagicStringCmd.stdout.splitlines():
try:
lineData = json.loads(line)
if self.fullyDrawnMagicString in lineData['eventMessage']:
magicStringEvent = lineData
except:
break

if magicStringEvent == '':
raise Exception("Didn't get the fully-drawn magic string event.")

timeToMagicStringEventDateTime = datetime.strptime(magicStringEvent['timestamp'], '%Y-%m-%d %H:%M:%S.%f%z')

# startup time is time to the magic string event
totalTimeMilliseconds = (timeToMagicStringEventDateTime - timeToMainEventStartDateTime).total_seconds() * 1000
else:
# startup time is time to first draw
totalTimeMilliseconds = timeToMainMilliseconds + timeToFirstDrawMilliseconds

if i == 0:
# ignore the warmup iteration
Expand Down