Skip to content

[cDAC] Implement IXCLRDataStackWalk::Request support for CLRDATA_REQUEST_REVISION and CLRDATA_STACK_WALK_REQUEST_SET_FIRST_FRAME #112275

Closed

Description

@max-charlamb

#111759 only implements IXCLRDataStackWalk::Request for DACSTACKPRIV_REQUEST_FRAME_DATA. The following options need to be implemented:

  • CLRDATA_REQUEST_REVISION
  • CLRDATA_STACK_WALK_REQUEST_SET_FIRST_FRAME

Activity

  1. dotnet-policy-service commented on Feb 7, 2025

    @dotnet-policy-service
    Contributor

    Tagging subscribers to this area: @tommcdon
    See info in area-owners.md if you want to be subscribed.

  2. added
    enhancementProduct code improvement that does NOT require public API changes/additions
    and removed
    untriagedNew issue has not been triaged by the area owner
    on Feb 7, 2025
  3. added this to the 10.0.0 milestone on Feb 14, 2025
  4. modified the milestones: 10.0.0, 11.0.0 on Jul 7, 2025
  5. added a commit that references this issue on Feb 21, 2026
    b4a28da
  6. noahfalk commented on Jul 30, 2026

    @noahfalk
    Member

    CLRDATA_REQUEST_REVISION was handled in #128679 but CLRDATA_STACK_WALK_REQUEST_SET_FIRST_FRAME still remains and it appears windbg uses it.

  7. rcj1 commented on Aug 4, 2026

    @rcj1
    Contributor

    @noahfalk it does not appear that CLRDATA_STACK_WALK_REQUEST_SET_FIRST_FRAME has a meaningful effect on the advance of the stack walk, in the sequence of events that happens in windbg.

  8. noahfalk commented on Aug 4, 2026

    @noahfalk
    Member

    OK, does that mean windbg is likely to behave fine if we leave it unimplemented? My windbg testing didn't hit anything where our lack of support here mattered but the tests were only hunting for code coverage rather than input-argument-coverage.

  9. rcj1 commented on Aug 4, 2026

    @rcj1
    Contributor

    @noahfalk yes it should be fine

  10. noahfalk commented on Aug 4, 2026

    @noahfalk
    Member

    OK great, lets leave it unimplemented and I'm closing the issue because there is nothing more to do.

  11. locked and limited conversation to collaborators on Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-Diagnostics-cdacenhancementProduct code improvement that does NOT require public API changes/additions

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions