Skip to content

Some SVE fixes for code generation - #113860

Merged
kunalspathak merged 5 commits into
dotnet:mainfrom
kunalspathak:sve-fixes
Mar 25, 2025
Merged

kunalspathak merged 5 commits into
dotnet:mainfrom
kunalspathak:sve-fixes

Conversation

@kunalspathak

Copy link
Copy Markdown
Contributor

While working on agnostic VL, found out some discrepancies in SVE code we are generating.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 24, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@kunalspathak
kunalspathak marked this pull request as ready for review March 25, 2025 19:16
Copilot AI review requested due to automatic review settings March 25, 2025 19:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • src/coreclr/jit/emitarm64sve.cpp: Language not supported
  • src/coreclr/jit/hwintrinsiccodegenarm64.cpp: Language not supported

@kunalspathak

Copy link
Copy Markdown
Contributor Author

@dotnet/arm64-contrib @amanasifkhalid

@kunalspathak
kunalspathak merged commit d7347b5 into dotnet:main Mar 25, 2025
@kunalspathak
kunalspathak deleted the sve-fixes branch March 25, 2025 21:49
kunalspathak added a commit that referenced this pull request Apr 4, 2025
My #113860 exposed a bug in encoding of sve_mov, where we were wrongly skipping the encoding the Zm field and giving wrong instruction.

Fixes: #113939
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants