Repository navigation
Fix JsonSchemaExporter handling of extension data with global Disallow - #135271
Merged
eiriktsarpalis merged 1 commit intoOct 6, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-text-json |
|
Thanks for the quick PR ❤️! Any chance this will land in .NET 11 (or even 10)? I'm okay with not making to release day, but let's say by February? Or is this one of those things again, that will only make it to .NET Next? |
Member
Author
|
Hi @alexaka1, hoping to get this backported in time for GA in November. |
Member
Author
|
/backport to release/11.0 |
Contributor
|
Started backporting to |
Closed
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With global
UnmappedMemberHandling = Disallow,JsonSchemaExporteremitsadditionalProperties: falsefor types with[JsonExtensionData], althoughJsonSerializeraccepts and round-trips their extra properties. UseJsonTypeInfo.EffectiveUnmappedMemberHandlingso the exporter honors the same extension-data override while ordinary types remain strict.Shared regression coverage checks both exporter overloads and serializer round-tripping for global
SkipandDisallow, with reflection and source generation. The regression fails before the fix and passes afterward on CoreCLR and .NET Framework 4.8.1. Full affected inner-loop suites: 131,214 passed, zero failed, 17 existing skips.Resolves #135258
Note
This pull request was generated with GitHub Copilot.