Repository navigation
[release/11.0] Fix JsonSchemaExporter handling of extension data with global Disallow - #135280
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
#135271) <!-- --> With global `UnmappedMemberHandling = Disallow`, `JsonSchemaExporter` emits `additionalProperties: false` for types with `[JsonExtensionData]`, although `JsonSerializer` accepts and round-trips their extra properties. Use `JsonTypeInfo.EffectiveUnmappedMemberHandling` so the exporter honors the same extension-data override while ordinary types remain strict. Shared regression coverage checks both exporter overloads and serializer round-tripping for global `Skip` and `Disallow`, with reflection and source generation. The regression fails before the fix and passes afterward on CoreCLR and .NET Framework 4.8.1. Full affected inner-loop suites: 131,214 passed, zero failed, 17 existing skips. Resolves #135258 > [!NOTE] > This pull request was generated with GitHub Copilot. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Member
|
I misunderstood this issue as being a new bug introduced in .NET 11 but in fact it has been reproducible since .NET 9. Therefore, it does not meet the bar for servicing. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-text-json |
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #135271 to release/11.0
/cc @eiriktsarpalis
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.