Skip to content

Disable distributed transactions test - #78468

Merged
roji merged 1 commit into
dotnet:mainfrom
roji:DisableOleTxTest
Nov 16, 2022
Merged

roji merged 1 commit into
dotnet:mainfrom
roji:DisableOleTxTest

Conversation

@roji

@roji roji commented Nov 16, 2022

Copy link
Copy Markdown
Member

@ghost ghost assigned roji Nov 16, 2022
@ghost

ghost commented Nov 16, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @roji
See info in area-owners.md if you want to be subscribed.

Issue Details

See #77241 (comment)

Author: roji
Assignees: roji
Labels:

area-System.Transactions

Milestone: -

Comment thread src/libraries/System.Transactions.Local/tests/OleTxTests.cs Outdated

[ConditionalFact(nameof(IsRemoteExecutorSupportedAndNotNano))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/77241")]
public void ImplicitDistributedTransactions_cannot_be_changed_after_being_read_as_true()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the ImplicitDistributedTransactions_cannot_be_changed_after_being_read_as_false right below this also be disabled?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing a test failure for that in #77241, did I miss another failure somewhere?

I agree that the failure likely isn't specifically related to ImplicitDistributedTransactions_cannot_be_changed_after_being_read_as_true, and part of the reason for disabling it is to see if the failure slips to another test, which may provide a bit more information... Any thoughts?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any failures for that one either so that sounds good to me.

@roji
roji merged commit 0f412b1 into dotnet:main Nov 16, 2022
@roji
roji deleted the DisableOleTxTest branch November 16, 2022 20:21
@ghost ghost locked as resolved and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants