Skip to content

Disable distributed transactions test #78468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roji merged 1 commit into from
Nov 16, 2022
Merged

Disable distributed transactions test #78468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.Transactions.Local/tests/OleTxTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,7 @@ public void ImplicitDistributedTransactions_cannot_be_changed_after_being_set()
}

[ConditionalFact(nameof(IsRemoteExecutorSupportedAndNotNano))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/77241")]
public void ImplicitDistributedTransactions_cannot_be_changed_after_being_read_as_true()

@jakobbotsch jakobbotsch Nov 16, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the ImplicitDistributedTransactions_cannot_be_changed_after_being_read_as_false right below this also be disabled?

@roji roji Nov 16, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing a test failure for that in #77241, did I miss another failure somewhere?

I agree that the failure likely isn't specifically related to ImplicitDistributedTransactions_cannot_be_changed_after_being_read_as_true, and part of the reason for disabling it is to see if the failure slips to another test, which may provide a bit more information... Any thoughts?

@jakobbotsch jakobbotsch Nov 16, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any failures for that one either so that sounds good to me.

{
// Temporarily skip on 32-bit where we have an issue.
Expand Down