Repository navigation
Remove PackageVersionPropsFlowType workaround in sourcelink - #45875
Merged
Merged
Conversation
ghost
added
ViktorHofer
marked this pull request as ready for review
January 10, 2025 20:50
ViktorHofer
enabled auto-merge (squash)
January 10, 2025 20:50
ViktorHofer
disabled auto-merge
January 10, 2025 20:50
mthalman
approved these changes
Jan 10, 2025
Member
|
Can we remove the support for the AllPackages flow type, or is it still used somewhere else? |
Member
Author
|
Question for @dotnet/source-build |
Member
|
Looks like we can't remove it. It's still used to construct the PackageVersions.props file, which is still used in the build today (both from the build.sh script and from within the bootstrapping projects) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/sourcelink#964