You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add System.Text.Json and System.Reflection.Metadata to Version Details #964
Dependency flow needs to be enabled for System.Text.Json and System.Reflection.Metadata in order to prevent prebuilts from occurring in source-build for this repo.
@mthalman I think this change works, but SBRPs for the two deps are the right way to go. They don't appear in the output packages, and depending on previously source built packages here seems like the wrong thing to do.
I'd love to know why i just got a github notification about this random issue but I can't work it out.. I am not subscribed or watching.. no one has mentioned me.. it remains an enigma ;-)
Since it's been a while since this issue has been opened, we should get a clear picture of what needs to be done by reverting this change: dotnet/installer#15632. That would add back PVP flow to the repo and we can see what prebuilts exist, if any.
Activity
mmitche commentedon Feb 27, 2023
@mthalman I think this change works, but SBRPs for the two deps are the right way to go. They don't appear in the output packages, and depending on previously source built packages here seems like the wrong thing to do.
dazinator commentedon Apr 28, 2023
I'd love to know why i just got a github notification about this random issue but I can't work it out.. I am not subscribed or watching.. no one has mentioned me.. it remains an enigma ;-)
ViktorHofer commentedon Jan 10, 2025
@mthalman @mmitche we still have a TODO pointing to this issue in the VMR sourcelink project: https://github.com/dotnet/sdk/blob/16ccea5ffefe59f4724a3f5ba527b8d36e050e7c/src/SourceBuild/content/repo-projects/sourcelink.proj#L6-L7
Can you please help me better understand what needs to be done here?
mthalman commentedon Jan 10, 2025
Since it's been a while since this issue has been opened, we should get a clear picture of what needs to be done by reverting this change: dotnet/installer#15632. That would add back PVP flow to the repo and we can see what prebuilts exist, if any.