Skip to content

Add System.Text.Json and System.Reflection.Metadata to Version Details #964

Closed
dotnet/sdk
#45875

Description

@mthalman

Dependency flow needs to be enabled for System.Text.Json and System.Reflection.Metadata in order to prevent prebuilts from occurring in source-build for this repo.

Related to dotnet/installer#15437

Activity

  1. mmitche commented on Feb 27, 2023

    @mmitche
    Member

    @mthalman I think this change works, but SBRPs for the two deps are the right way to go. They don't appear in the output packages, and depending on previously source built packages here seems like the wrong thing to do.

  2. dazinator commented on Apr 28, 2023

    @dazinator

    I'd love to know why i just got a github notification about this random issue but I can't work it out.. I am not subscribed or watching.. no one has mentioned me.. it remains an enigma ;-)

  3. ViktorHofer commented on Jan 10, 2025

    @ViktorHofer
    Member

    @mthalman @mmitche we still have a TODO pointing to this issue in the VMR sourcelink project: https://github.com/dotnet/sdk/blob/16ccea5ffefe59f4724a3f5ba527b8d36e050e7c/src/SourceBuild/content/repo-projects/sourcelink.proj#L6-L7

    Can you please help me better understand what needs to be done here?

  4. mthalman commented on Jan 10, 2025

    @mthalman
    MemberAuthor

    Since it's been a while since this issue has been opened, we should get a clear picture of what needs to be done by reverting this change: dotnet/installer#15632. That would add back PVP flow to the repo and we can see what prebuilts exist, if any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions