Skip to content

Restore generated assets in Microsoft.CodeAnalysis.NetAnalyzers packages - #55899

Merged
tannergooding merged 6 commits into
mainfrom
copilot/fix-rulesets-subdirectory-issue
Sep 15, 2026
Merged

Restore generated assets in Microsoft.CodeAnalysis.NetAnalyzers packages#55899
tannergooding merged 6 commits into
mainfrom
copilot/fix-rulesets-subdirectory-issue

Conversation

Copilot AI commented Aug 23, 2026 •
edited by jeffhandley
Loading

Copy link
Copy Markdown
Contributor

Clean one-pass packing evaluated generated-file globs before their outputs existed, omitting rulesets, editorconfigs, global analyzer configs, and buildTransitive integration files. This also prevented package-provided analyzers such as CA1416 from receiving required MSBuild properties.

  • Correct pack ordering
    • Move generated-file inclusion into a target that runs after asset generation and before NuGet gathers package files.

@azure-pipelines

azure-pipelines Bot commented Aug 23, 2026

Copy link
Copy Markdown
Azure Pipelines:
3 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI linked an issue Aug 23, 2026 that may be closed by this pull request
rulesets subdirectory missing from published NetAnalyzers nupkg #54046
Closed
Copilot AI and others added 3 commits August 23, 2026 21:40
@jeffhandley
Include generated NetAnalyzers assets during pack
65fac1c 
Co-authored-by: jeffhandley <1031940+jeffhandley@users.noreply.github.com>
@jeffhandley
Validate generated NetAnalyzers package assets
f7ea4d5 
Co-authored-by: jeffhandley <1031940+jeffhandley@users.noreply.github.com>
@jeffhandley
Clarify expected analyzer package files
491ba84 
Co-authored-by: jeffhandley <1031940+jeffhandley@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix missing rulesets subdirectory in published NetAnalyzers package Restore generated assets in Microsoft.CodeAnalysis.NetAnalyzers packages Aug 23, 2026
Copilot AI requested a review from jeffhandley August 23, 2026 21:54
@jeffhandley
Remove redundant NetAnalyzers package validation
b4f9b74 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 1b62fb4f-3669-466b-bbcf-d0384626535c
@jeffhandley
jeffhandley marked this pull request as ready for review August 24, 2026 05:35
@jeffhandley
jeffhandley requested a review from a team as a code owner August 24, 2026 05:35
@jeffhandley
jeffhandley requested review from ViktorHofer and a lite review from Copilot August 24, 2026 05:35
@azure-pipelines

azure-pipelines Bot commented Aug 24, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI reviewed Aug 24, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Microsoft.CodeAnalysis.NetAnalyzers package packing process so generated assets (rulesets, editorconfigs, global analyzer configs, and buildTransitive integration files) are included reliably by moving their inclusion from evaluation-time globs to a target that runs after generation and before NuGet collects package files.

Changes:

  • Removed evaluation-time <None Include=".../**/*" Pack="true" ... /> entries that could be empty during a clean pack.
  • Added IncludeGeneratedFilesInPackage target to inject the generated files into the packing item graph after GenerateAnalyzerConfigAndDocumentationFiles runs.

Comment thread src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers.Package.csproj Resolved
Comment thread src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers.Package.csproj Resolved
@jeffhandley
Use established NetAnalyzers pack hook
9274f0b 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 1b62fb4f-3669-466b-bbcf-d0384626535c
ViktorHofer
ViktorHofer approved these changes Aug 24, 2026
View reviewed changes

@ViktorHofer ViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We noticed the same just last week. Thanks for fixing. Interestingly this did work before so something must have changed.

@tannergooding
tannergooding merged commit c46278c into main Sep 15, 2026
22 checks passed
@tannergooding
tannergooding deleted the copilot/fix-rulesets-subdirectory-issue branch September 15, 2026 19:57
@tannergooding

tannergooding commented Sep 15, 2026

Copy link
Copy Markdown
Member

/backport to release/11.0.1xx

@tannergooding

tannergooding commented Sep 15, 2026

Copy link
Copy Markdown
Member

/backport to release/10.0.1xx

@tannergooding

tannergooding commented Sep 15, 2026

Copy link
Copy Markdown
Member

/backport to release/10.0.4xx

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Started backporting to release/10.0.1xx (link to workflow run)

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Started backporting to release/11.0.1xx (link to workflow run)

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Started backporting to release/10.0.4xx (link to workflow run)

This was referenced Sep 15, 2026
Merged
Merged
Merged
@dotnet-maestro dotnet-maestro Bot mentioned this pull request Sep 16, 2026
Merged
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@ViktorHofer ViktorHofer ViktorHofer approved these changes
+1 more reviewer
@jeffhandley jeffhandley jeffhandley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jeffhandley jeffhandley

Copilot code review Copilot

Labels

Area-Microsoft.CodeAnalysis.NetAnalyzers

Projects

None yet

Milestone

12.0-preview1

6 participants

@tannergooding @jeffhandley @ViktorHofer @marcpopMSFT