Skip to content

Restore generated assets in Microsoft.CodeAnalysis.NetAnalyzers packages #55899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 6 commits into from
Sep 15, 2026
Merged

Restore generated assets in Microsoft.CodeAnalysis.NetAnalyzers packages #55899

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f1e1b1d
Initial plan
Copilot Aug 23, 2026
65fac1c
Include generated NetAnalyzers assets during pack
Copilot Aug 23, 2026
f7ea4d5
Validate generated NetAnalyzers package assets
Copilot Aug 23, 2026
491ba84
Clarify expected analyzer package files
Copilot Aug 23, 2026
b4f9b74
Remove redundant NetAnalyzers package validation
jeffhandley Aug 24, 2026
9274f0b
Use established NetAnalyzers pack hook
jeffhandley Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions ...icrosoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers.Package.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,6 @@
<None Include="assets\uninstall.ps1" Pack="true" PackagePath="/tools" />
</ItemGroup>

<ItemGroup>
<None Include="$(GeneratedRulesetsDir)/**/*" Pack="true" PackagePath="/rulesets" Visible="false" />
<None Include="$(GeneratedEditorconfigsDir)/**/*" Pack="true" PackagePath="/editorconfig" Visible="false" />
<None Include="$(GeneratedGlobalAnalyzerConfigsDir)/**/*" Pack="true" PackagePath="/buildTransitive/config" Visible="false" />
<None Include="$(PackagePropsTargetsFileDir)/**/*" Pack="true" PackagePath="/buildTransitive" Visible="false" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="Microsoft.CodeAnalysis.NetAnalyzers\Microsoft.CodeAnalysis.NetAnalyzers.csproj" PackAsAnalyzer="true" />
<ProjectReference Include="Microsoft.CodeAnalysis.CSharp.NetAnalyzers\Microsoft.CodeAnalysis.CSharp.NetAnalyzers.csproj" PackAsAnalyzer="true" />
Expand Down Expand Up @@ -103,4 +96,15 @@
<Exec Command='"$(DotNetTool)" "$(_GenerateDocumentationAndConfigFilesPath)" "-validateOnly:$(ValidateOnlyFlag)" "$(GeneratedRulesetsDir)" "$(GeneratedEditorconfigsDir)" "$(GeneratedGlobalAnalyzerConfigsDir)" "$(ArtifactsBinDir)$(EscapeDirectorySuffix)" "$(Configuration)" "$(TargetFramework)" "@(AnalyzerNupkgAssembly)" "$(PackagePropsTargetsFileDir)" "$(PackagePropsFileName)" "$(PackagePropsTargetsFileDir)" "$(PackageTargetsFileName)" "$(DisableNETAnalyzersPackagePropsFileName)" "$(AnalyzerDocumentationFileDir)" "$(AnalyzerDocumentationFileName)" "$(AnalyzerSarifFileDir)" "$(AnalyzerSarifFileName)" "$(VersionPrefix)" $(PackageId) $(ContainsPortedFxCopRules) $(GenerateAnalyzerRulesMissingDocumentationFile) $(ReleaseTrackingOptOut) $(_ValidateOffline)' />
</Target>

<Target Name="IncludeGeneratedFilesInPackage"
BeforeTargets="$(GenerateNuspecDependsOn)"
DependsOnTargets="GenerateAnalyzerConfigAndDocumentationFiles">
<ItemGroup>
<None Include="$(GeneratedRulesetsDir)/**/*" Pack="true" PackagePath="/rulesets" Visible="false" />
<None Include="$(GeneratedEditorconfigsDir)/**/*" Pack="true" PackagePath="/editorconfig" Visible="false" />
<None Include="$(GeneratedGlobalAnalyzerConfigsDir)/**/*" Pack="true" PackagePath="/buildTransitive/config" Visible="false" />
<None Include="$(PackagePropsTargetsFileDir)/**/*" Pack="true" PackagePath="/buildTransitive" Visible="false" />
Comment thread
jeffhandley marked this conversation as resolved.
Resolved
</ItemGroup>
</Target>

</Project>
Loading