Repository navigation
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: joeloff <7409981+joeloff@users.noreply.github.com>
3 tasks
…ature-verification
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused port matches the source change and introduces no unresolved issues.
0 open findings
What changed in this PR
Ports the MSI signature-verification fix from PR #56468 to the release branch.
Changes:
- Exposes the existing MSI signature verifier internally.
- Verifies MSI signatures before administrative manifest extraction.
| File | Description |
|---|---|
MsiPackageCache.cs |
Makes signature verification internally accessible. |
NetSdkMsiInstallerClient.cs |
Verifies the MSI before invoking Windows Installer. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
joeloff
changed the title
joeloff
changed the title
marcpopMSFT
approved these changes
Oct 16, 2026
joeloff
deleted the
copilot/release-1001xx-port-signature-verification
branch
October 16, 2026 21:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MsiPackageCache.VerifyPackageSignatureinternal onrelease/10.0.1xx.ExtractManifestAsync.