Repository navigation
[release/10.0.4xx] Verify MSI signature before manifest extraction. - #56468
Merged
joeloff merged 3 commits intoOct 16, 2026
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change correctly reuses existing signature policy before MSI execution.
Review effort: Balanced
Findings: None
What changed in this PR
Ensures MSI workload manifests are signature-verified before administrative extraction.
Changes:
- Exposes the existing MSI signature verifier internally.
- Invokes verification before
InstallProduct.
| File | Description |
|---|---|
MsiPackageCache.cs |
Makes signature verification callable internally. |
NetSdkMsiInstallerClient.cs |
Verifies MSI signatures before extraction. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 1, 2026
Copilot AI
added a commit
that referenced
this pull request
Oct 1, 2026
Co-authored-by: joeloff <7409981+joeloff@users.noreply.github.com>
This was referenced Oct 5, 2026
joeloff
changed the title
marcpopMSFT
approved these changes
Oct 14, 2026
Member
Author
|
/ba-g MAX_PATH issue on netfx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The SDK may extract workload manifests upfront to determine if real changes to workloads are required. For MSI based installs, the SDK behaves inconsistent since it does not verify the MSI signature before calling
InstallProductto extract the manifest.Risk
Low
Testing
Manual verification