Skip to content

Fix sign conversion warning by casting to size_t - #695

Merged
limdor merged 1 commit into
eclipse-score:mainfrom
limdor:sign_conversion
Oct 16, 2026
Merged

limdor merged 1 commit into
eclipse-score:mainfrom
limdor:sign_conversion

Conversation

@limdor

@limdor limdor commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

No one should provide a negative argc. To make that clear we add a precondition.

Fixes #631

No one should provide a negative argc. To make that clear we add
a precondition.

Fixes eclipse-score#631
@github-project-automation github-project-automation Bot moved this to In Progress in BAS - Baselibs FT Oct 15, 2026
@limdor
limdor deployed to workflow-approval October 15, 2026 13:08 — with GitHub Actions Active
@limdor
limdor temporarily deployed to workflow-approval October 15, 2026 13:08 — with GitHub Actions Inactive
@limdor
limdor temporarily deployed to workflow-approval October 15, 2026 13:08 — with GitHub Actions Inactive
@limdor
limdor temporarily deployed to workflow-approval October 15, 2026 13:08 — with GitHub Actions Inactive
@limdor
limdor temporarily deployed to workflow-approval October 15, 2026 13:08 — with GitHub Actions Inactive
@github-actions github-actions Bot added c++ C++ code comp-string_manipulation Related to score/string_manipulation component bazel Bazel and Starlark build files labels Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-695: https://eclipse-score.github.io/baselibs/pr-695/

@limdor
limdor enabled auto-merge October 15, 2026 13:58
@github-project-automation github-project-automation Bot moved this from In Progress to On Hold in BAS - Baselibs FT Oct 16, 2026
@limdor
limdor added this pull request to the merge queue Oct 16, 2026
Merged via the queue into eclipse-score:main with commit c83db5d Oct 16, 2026
28 checks passed
@limdor
limdor deleted the sign_conversion branch October 16, 2026 06:57
@github-project-automation github-project-automation Bot moved this from On Hold to Done in BAS - Baselibs FT Oct 16, 2026

This branch was previously deployed

1 inactive deployment
workflow-approval — 1c3932c7 Deployed Oct 15, 2026 by limdor via Build and Test score-qnx-aarch64 / approval #2372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bazel Bazel and Starlark build files c++ C++ code comp-string_manipulation Related to score/string_manipulation component

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Sign conversion warning in score::string_manipulation::GetArguments

2 participants