Skip to content

Fix sign conversion warning by casting to size_t #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
limdor merged 1 commit into from
Oct 16, 2026
Merged

Fix sign conversion warning by casting to size_t #695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions score/string_manipulation/arguments/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,14 @@

load("@rules_cc//cc:defs.bzl", "cc_library")
load("@score_baselibs//:bazel/unit_tests.bzl", "cc_gtest_unit_test")
load("@score_baselibs//score/language/safecpp:toolchain_features.bzl", "COMPILER_WARNING_FEATURES")

cc_library(
name = "arguments",
srcs = ["arguments.cpp"],
hdrs = ["arguments.h"],
features = COMPILER_WARNING_FEATURES,
implementation_deps = ["//score/language/futurecpp"],
visibility = ["//visibility:public"],
deps = ["@score_baselibs//score/language/safecpp/string_view:zstring_view"],
)
Expand Down
4 changes: 3 additions & 1 deletion score/string_manipulation/arguments/arguments.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,14 @@
********************************************************************************/

#include "score/string_manipulation/arguments/arguments.h"
#include <score/assert.hpp>
#include <cstring>

std::vector<score::safecpp::zstring_view> score::string_manipulation::GetArguments(int argc, const char* argv[])
{
SCORE_LANGUAGE_FUTURECPP_PRECONDITION(argc >= 0);
std::vector<safecpp::zstring_view> arguments;
arguments.reserve(argc);
arguments.reserve(static_cast<std::size_t>(argc));
for (int i = 0; i < argc; i++)
{
// We need to use strlen because zstring_view does not support char* construct
Expand Down
Loading