Repository navigation
coverage fix - #165
Merged
MaximilianSoerenPollak merged 2 commits intoJul 29, 2026
Merged
coverage fix#165
Conversation
Test language/tag filters only control which tests RUN - with wildcard target patterns, bazel coverage still BUILDS filtered-out test targets. This broke consumers with Miri tests once score_toolchains_rust 0.9.2 enabled Rust coverage instrumentation: the Miri test subgraph is compiled against the Miri sysroot, which does not ship the profiler_builtins crate that instrumented compiles require (error[E0463], aborting the whole coverage invocation and killing in-flight C++ tests). With --build_tests_only the filters apply to building as well, so excluded tests are neither run nor built. Verified on eclipse-score/lifecycle#369: without the flag the job fails at 16/19 tests; with it, exit 0 and 19/19 tests pass. Fixes #164
Same hardening as cpp-coverage (see #164): make consumers' --test_lang_filters/--test_tag_filters apply to building as well, so filtered-out tests (e.g. Miri targets, whose Miri-sysroot compiles fail under coverage instrumentation) are neither run nor built. Consumers that already pass --build_tag_filters (e.g. lifecycle's rust job with -miri,-loom) are unaffected; this protects the ones relying on test filters alone. Refs #164
dcalavrezo-qorix
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
PiotrKorkus,
lurtz,
nradakovic,
opajonk and
pawelrutkaq
as code owners
July 29, 2026 08:38
MaximilianSoerenPollak
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pass --build_tests_only to bazel coverage