Skip to content

coverage fix #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaximilianSoerenPollak merged 2 commits into from
Jul 29, 2026
Merged

coverage fix #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
815bd64
cpp-coverage: pass --build_tests_only to bazel coverage
dcalavrezo-qorix Jul 29, 2026
eddd1a3
rust-coverage: pass --build_tests_only to bazel test
dcalavrezo-qorix Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/cpp-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,12 @@ jobs:
set -euo pipefail
set -f # disable globbing

cmd=(bazel coverage)
# --build_tests_only: restrict building to test targets that pass the
# test filters. Without it, wildcard patterns build even filtered-out
# tests (e.g. --test_lang_filters=-rust,-miri still BUILDS Miri test
# targets, whose Miri-sysroot compiles fail under coverage
# instrumentation). See issue #164.
cmd=(bazel coverage --build_tests_only)

if [[ -n "${BAZEL_CONFIG}" ]]; then
cmd+=(--config="${BAZEL_CONFIG}")
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/rust-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,14 @@ jobs:
- name: Run Rust tests with coverage instrumentation
run: |
set -euo pipefail
echo "Running: bazel test ${{ inputs.bazel-test-config-flags }} ${{ inputs.bazel-test-args }} ${{ inputs.bazel-test-targets }}"
bazel test ${{ inputs.bazel-test-config-flags }} ${{ inputs.bazel-test-args }} ${{ inputs.bazel-test-targets }}
# --build_tests_only: restrict building to test targets that pass the
# test filters, so consumers' --test_lang_filters/--test_tag_filters
# also exclude filtered tests from BUILDING. Without it, wildcard
# patterns build even filtered-out tests (e.g. Miri targets, whose
# Miri-sysroot compiles fail when coverage instrumentation is
# enabled). See issue #164.
echo "Running: bazel test --build_tests_only ${{ inputs.bazel-test-config-flags }} ${{ inputs.bazel-test-args }} ${{ inputs.bazel-test-targets }}"
bazel test --build_tests_only ${{ inputs.bazel-test-config-flags }} ${{ inputs.bazel-test-args }} ${{ inputs.bazel-test-targets }}

- name: Generate coverage reports
run: |
Expand Down
Loading