Skip to content

Fix verbose dash-licenses invocation - #10

Merged
umaucher merged 2 commits into
eclipse-score:mainfrom
umaucher:fix-jvm-options-dash-license-scan
Sep 28, 2026
Merged

umaucher merged 2 commits into
eclipse-score:mainfrom
umaucher:fix-jvm-options-dash-license-scan

Conversation

@umaucher

Copy link
Copy Markdown
Contributor

Fix the Java CLI invocation used by verbose scans.

  • Place the SLF4J JVM property before -jar.
  • Preserve the required - stdin marker.
  • Add regression coverage for the generated command.

Validation: uv run pytest tests/test_main.py (4 passed).
The end-to-end scan reaches Dash successfully; exit code 32 reflects restricted/unverified dependency findings.

@AlexanderLanin AlexanderLanin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this why defaultLogLevel=debug had no effect in the past?

@umaucher

Copy link
Copy Markdown
Contributor Author

it had some effect to some extend:

$ dash-license-scan -v ../persistency/score/kvs/tests/test_cases/requirements.txt.lock ../persistency/bazel-persistency/external/score_docs_as_code+/src/requirements.txt
DEBUG:dash_license_scan.main:Starting dash_license_scan.main(None)
[...]

but basically in the end leads to:

DEBUG:dash_license_scan.main:Command: java -jar /home/umaucher/Projects/git/eclipse-score/dash-license-scan/src/dash_license_scan/resources/org.eclipse.dash.licenses-1.1.0.jar -summary /tmp/dash-license-scan-summary-oo9w27ak.txt -Dorg.slf4j.simpleLogger.defaultLogLevel=debug -
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

Dash Licenses Summary Output:

"unknow parameter" error 127

@umaucher
umaucher merged commit 430d270 into eclipse-score:main Sep 28, 2026
12 checks passed
@umaucher
umaucher deleted the fix-jvm-options-dash-license-scan branch September 28, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants