Repository navigation
Conversation
umaucher
force-pushed
the
um_dash_requirements_lockfile
branch
2 times, most recently
from
September 28, 2026 08:04
22ea694 to
6432b97
Compare
umaucher
changed the title
umaucher
force-pushed
the
um_dash_requirements_lockfile
branch
from
September 28, 2026 08:06
6432b97 to
403493c
Compare
umaucher
force-pushed
the
um_dash_requirements_lockfile
branch
from
September 28, 2026 08:07
403493c to
2b64b7f
Compare
umaucher
marked this pull request as ready for review
September 28, 2026 08:09
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Use the parsed non-empty row count so whitespace-only summaries are treated as unavailable.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds diagnostics and failure handling for Python DASH license enrichment.
Changes:
- Extends timeout handling to 30 minutes with distinct timeout diagnostics.
- Logs scan and summary metrics.
- Adds timeout and empty-summary tests.
| File | Summary |
|---|---|
scripts/generate_python_metadata_cache.py |
Adds diagnostics, timeout handling, and summary validation; whitespace-only summaries remain incorrectly usable. |
tests/test_generate_python_metadata_cache.py |
Adds timeout and empty-summary coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if summary.is_file() | ||
| else 0 | ||
| ) | ||
| summary_usable = summary_bytes > 0 |
| ] | ||
| start_time = time.monotonic() | ||
| print( | ||
| f"INFO: Starting DASH Python license scan for {len(lockfiles)} lockfile(s): " |
Member
There was a problem hiding this comment.
doesnt in already print that info on startup?
Member
There was a problem hiding this comment.
Maybe pass -v parameter if you want more output?
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
|
replaced by #15 |
1 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds diagnostics for Python DASH license enrichment and rejects empty summaries.
Validated with
bazel test //tests:test_generate_python_metadata_cache --test_output=errors.