Skip to content

Feature/closing test coverage of the control provider class - #789

Merged
MaciejKaszynski merged 6 commits into
eclipse-score:mainfrom
etas-contrib:feature/closing_test_coverage_of_the_ControlProvider_class
Oct 15, 2026
Merged

Feature/closing test coverage of the control provider class#789
MaciejKaszynski merged 6 commits into
eclipse-score:mainfrom
etas-contrib:feature/closing_test_coverage_of_the_ControlProvider_class

Conversation

@SimonKozik

@SimonKozik SimonKozik commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Refactoring the ControlProvider class and providing 100% coverage.

Please note that ControlProvider was changed to become a specific instantiation of BasicControlProvider template, which has injectable dependencies for testing.

@SimonKozik

SimonKozik commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

Part of #325 100% coverage for ControlProvider.

@danth danth mentioned this pull request Oct 14, 2026
Open
danth
danth suggested changes Oct 14, 2026
View reviewed changes

@danth danth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation changes look OK :)) I have some comments about the unit tests.

Comment thread score/launch_manager/src/daemon/src/control/control_provider_UT.cpp
Comment thread score/launch_manager/src/daemon/src/control/control_provider_UT.cpp
Comment thread score/launch_manager/src/daemon/src/control/control_provider_UT.cpp
Comment thread score/launch_manager/src/daemon/src/control/control_provider_UT.cpp
Comment thread score/launch_manager/src/daemon/src/control/control_provider_UT.cpp Outdated
Comment thread score/launch_manager/src/daemon/src/control/control_provider.hpp
@danth

danth commented Oct 14, 2026

Copy link
Copy Markdown
Member

Part of #325 100% coverage for ControlProvider.

Should this be linked to #685?

@github-actions

github-actions Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-789: https://eclipse-score.github.io/lifecycle/pr-789/

@SimonKozik
SimonKozik force-pushed the feature/closing_test_coverage_of_the_ControlProvider_class branch from d69eca7 to 4426f89 Compare October 15, 2026 10:58
@SimonKozik
SimonKozik force-pushed the feature/closing_test_coverage_of_the_ControlProvider_class branch from 4426f89 to 49e3893 Compare October 15, 2026 14:08
danth
danth approved these changes Oct 15, 2026
View reviewed changes

@danth danth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :))

CC @MaciejKaszynski @NicolasFussberger

@MaciejKaszynski
MaciejKaszynski added this pull request to the merge queue Oct 15, 2026
Merged via the queue into eclipse-score:main with commit 876c5df Oct 15, 2026
29 of 38 checks passed
@MaciejKaszynski
MaciejKaszynski deleted the feature/closing_test_coverage_of_the_ControlProvider_class branch October 15, 2026 15:47
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Oct 15, 2026
This was referenced Oct 25, 2026
Open
Open

This branch is waiting to be deployed

1 waiting deployment
workflow-approval — b85f95bc Waiting Oct 15, 2026 by SimonKozik via Build and test unit-tests-arm64-qnx / approval #1500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaciejKaszynski MaciejKaszynski MaciejKaszynski approved these changes
@NicolasFussberger NicolasFussberger Awaiting requested review from NicolasFussberger NicolasFussberger is a code owner
@pawelrutkaq pawelrutkaq Awaiting requested review from pawelrutkaq pawelrutkaq is a code owner
@ramceb ramceb Awaiting requested review from ramceb ramceb is a code owner
@FScholPer FScholPer Awaiting requested review from FScholPer FScholPer is a code owner
@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner
@anmittag anmittag Awaiting requested review from anmittag anmittag is a code owner
+1 more reviewer
@danth danth danth approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

LCM - Lifecycle & Health FT
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SimonKozik @danth @MaciejKaszynski