Skip to content

Feature/closing test coverage of the control provider class #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaciejKaszynski merged 6 commits into from
Oct 15, 2026
Merged

Feature/closing test coverage of the control provider class #789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
207a0c3
Preparing ControlProvider class for unit testing
SimonKozik Oct 8, 2026
340ed1f
Refactored unit tests for control_provider
SimonKozik Oct 14, 2026
69b52af
Moving asserts to the better place, as per review comments
SimonKozik Oct 15, 2026
d68d7b8
Adding checks for stdin, stdout and stderr as per review comment
SimonKozik Oct 15, 2026
49e3893
Running clang-format on changed files
SimonKozik Oct 15, 2026
b85f95b
Cosmetic changes to the description, as per review comment
SimonKozik Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions score/launch_manager/src/daemon/src/control/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ load("//tests/utils/bazel:unit_test.bzl", "lm_cc_test")

cc_library(
name = "control_provider",
srcs = ["control_provider.cpp"],
hdrs = ["control_provider.hpp"],
include_prefix = "score/mw/launch_manager/control",
strip_include_prefix = "/score/launch_manager/src/daemon/src/control",
Expand All @@ -31,17 +30,11 @@ cc_library(
lm_cc_test(
name = "control_provider_UT",
srcs = ["control_provider_UT.cpp"],
args = [
"--service_instance_manifest",
"$(rootpath control_provider_test_mw_com_config.json)",
],
data = ["control_provider_test_mw_com_config.json"],
linkopts = ["-Wl,--wrap=fcntl"],
deps = [
":control_provider",
"//score/launch_manager:error",
"//score/launch_manager/src/daemon/src/process_group_manager:irun_target_control",
"@googletest//:gtest",
"@score_baselibs//score/string_manipulation/arguments",
"@score_communication//score/mw/com",
"@googletest//:gtest_main",
],
)
245 changes: 0 additions & 245 deletions score/launch_manager/src/daemon/src/control/control_provider.cpp
View file
Open in desktop

This file was deleted.

Loading
Loading